On 11/26/10 5:25 PM, "Patrick Schmidt" <p.l.schm...@gmx.de> wrote: > Am 26.11.2010 um 23:41 schrieb carl.d.soren...@gmail.com: > >> On 2010/11/26 19:39:06, steve.yegge wrote: >>> I also tried out the zero-fingering feature. It works quite well in >> conjunction >>> with setting the minimumFret. Again, I found no bugs, although my >> testing >>> shouldn't be considered exhaustive. >> >> I think it should work, and we haven't found any bugs yet, so once we >> get a style review we should be able to go ahead and push. If bugs >> show >> up later, we'll fix them. >>
Neil found a bug in the code. What happens when someone requests an open string that isn't present in the tuning? I've got the code fixed to issue a warning. After issuing the warning, we have two choices: 1 -- leave the improper pitch out of the tablature (which will leave a 0 fingering in the Staff and no corresponding pitch in the tablature) 2 -- calculate that pitch as part of the tablature, will will leave a 0 fingering in the Staff and a non-zero fret in the tablature. Which would be preferable? Thanks, Carl
BadZero1.pdf
Description: BadZero1.pdf
BadZero2.png
Description: BadZero2.png
_______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
