On Mon, 08 Nov 2010 11:14:11 -0800, Mark Polesky <[email protected]> wrote:


Similarly, I think the two 'staff-staff-spacing properties
would be intuitive and easy enough to keep separate,
mentally:

  % space between consecutive staves in a system
  \override VerticalAxisGroup #'staff-staff-spacing

  % space between consecutive staves in a staff-group
  \override StaffGrouper #'staff-staff-spacing

Thoughts?


From the users' point of view, your suggestion is a clear improvement.  The two 
properties have the same form and the same function, so you would spare us the 
trouble of remembering that they are the same.

But before folding two property names together, you should search for uses of 
the old names, to check whether the code ever assumes that any object with a 
'between-staff-spacing' must be StaffGrouper, or if it ever assumes that 
anything with a 'next-staff-spacing' must be VerticalAxisGroup.  After a git 
grep for the two old names, only the function append_system() in 
page-layout-problem.cc looked like it might act differently if the names are 
merged.
--
Keith


_______________________________________________
lilypond-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to