n.putt...@gmail.com schrieb:
Hi Marc,
Hello Neil,
In hide-tab-note-head, you end up setting properties on bounds which
aren't noteheads (i.e., for broken bounds, the ties are bound by a
NonMusicalPaperColumn); till now you've got away with it, since the
properties being set were from the grob-interface (unlike 'details).
TO be honest, I don't understand what you mean here.
Try running `make check' to see what I mean. ;)
Here neither - I see I made a mistake, because `make check' fails, but
the output doesn't help a lot.
Cheers,
Neil
http://codereview.appspot.com/2191042/diff/1/input/regression/tablature-tie-slur-glissando.ly
File input/regression/tablature-tie-slur-glissando.ly (right):
http://codereview.appspot.com/2191042/diff/1/input/regression/tablature-tie-slur-glissando.ly#newcode1
input/regression/tablature-tie-slur-glissando.ly:1: \version "2.13.35"
"2.13.34"
Ok, done.
http://codereview.appspot.com/2191042/diff/1/input/regression/tablature-tie-slur-glissando.ly#newcode3
input/regression/tablature-tie-slur-glissando.ly:3: \header{ texidoc =
"If a slur or a glissando follows a tie, the
formatting
Done. Looking at various files in input/regression, I see there are
various formatting styles.
What about adding a file called template.ly or something similar, which
can be copied and
edited to avoid formatting issues?
http://codereview.appspot.com/2191042/diff/1/scm/define-grobs.scm
File scm/define-grobs.scm (right):
http://codereview.appspot.com/2191042/diff/1/scm/define-grobs.scm#newcode1979
scm/define-grobs.scm:1979: (tied-to . #f)))
On 2010/09/16 10:32:52, Carl wrote:
tied-from might be a better name than tied-to, since it's the property
of the
left-hand note that we're adjusting, rather than the property of the
right hand
note.
How about `tied-left'? It gives an indication of the direction of the
tie away from this notehead.
Carl answered to me off-list, and it seems that he misunderstood my
idea, so at the end, he was fine with
"tied-to".
http://codereview.appspot.com/2191042/diff/1/scm/tablature.scm
File scm/tablature.scm (right):
http://codereview.appspot.com/2191042/diff/1/scm/tablature.scm#newcode179
scm/tablature.scm:179: (define (hide-tab-note-head grob)
This is a bit of a misnomer, since it indirectly makes some heads
visible later. It would be better if you could avoid hiding such notes
rather than hiding them, then making them visible.
How can I avoid making heads invisible? The tie routine doesn't know
whether a slur or
glissando follows or not, so I have to make it invisible "to be on the
safe side", add a
mark to this note that it is tied to another one and read this
information by the slur/glissando
routine.
Or is it just the name? Well, I could use a more self-explanatory name,
but since it is just
a shortcut, I don't know whether it's worth the effort...
http://codereview.appspot.com/2191042/diff/1/scm/tablature.scm#newcode181
scm/tablature.scm:181: (ly:grob-set-property! grob 'whiteout #f)
can remove this
Done.
http://codereview.appspot.com/2191042/diff/1/scm/tablature.scm#newcode182
scm/tablature.scm:182: (ly:grob-set-nested-property! grob '(details
tied-to) #t))
This doesn't belong in 'details since it's set beyond the user's
control: it only makes sense as an internal property, so should be
defined separately
Done (I hope I did it right?)
http://codereview.appspot.com/2191042/diff/1/scm/tablature.scm#newcode186
scm/tablature.scm:186: (ly:grob-set-property! grob 'whiteout #t)
can remove this
Done.
http://codereview.appspot.com/2191042/diff/1/scm/tablature.scm#newcode275
scm/tablature.scm:275: (control-points (ly:grob-property grob
'control-points)))
remove
Yes, of course (these annoying little errors from cut&paste...)
http://codereview.appspot.com/2191042/diff/1/scm/tablature.scm#newcode277
scm/tablature.scm:277: (if tied-to
(and tied-to
(show-tab-note-head left-tab-note-head)
Done.
http://codereview.appspot.com/2191042/diff/1/scm/tablature.scm#newcode282
scm/tablature.scm:282: (ly:grob-set-nested-property! grob
'(bound-details left padding) 0.75)))
this won't happen for tied notes after a break unless you explicitly set
'tied-to outside `hide-tab-note-head'
I don't know what you mean - I tried to break everything ;-) and it
seems to work:
music = {
\override Glissando #'breakable = ##t
c'1 ~ \break c'1 ( \break d'1 )
c'1 ~ \break c'1 \glissando \break d'1
}
\score {
<<
\new Staff {
\new Voice {
\clef "G_8"
\music
}
}
\new TabStaff {
\new TabVoice {
\music
}
}
>>
}
Thanks,
Marc
http://codereview.appspot.com/2191042/
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
