Thanks, pushed. Wow, that's 2 Critical issues that you've fixed
today. Great job!
Cheers,
- Graham
On Wed, Mar 31, 2010 at 10:17 AM, Marc Hohl <m...@hohlart.de> wrote:
> Graham Percival schrieb:
>>
>> On Wed, Mar 31, 2010 at 12:01 AM, Marc Hohl <m...@hohlart.de> wrote:
>>
>>>
>>> diff --git a/Documentation/notation/fretted-strings.itely
>>> @@ -1470,13 +1470,33 @@ text markup.
>>> +...@lilypond[quote,ragged-right,verbatim]
>>> +music = \relative c' {
>>> + < a\3 \deadNote c\2 a'\1 >4
>>> + < b\3 \deadNote d\2 b'\1 >4
>>> + < c\3 \deadNote e\2 c'\1 >8
>>> + \deadNotesOn \times 2/3 { g16\3 b\2 e\1 } \deadNotesOff
>>>
>>
>> Predefined commands should go on their own lines unless they refer to
>> a single note. \deadNote is fine, but \deadNoteOn/Off should be on
>> separate lines.
>>
>>
>
> Ok, done.
>>>
>>> +\new StaffGroup <<
>>> + \new Staff {
>>> + \clef "treble_8"
>>> + \override Voice.StringNumber #'transparent = ##t
>>>
>>
>> Is this absolutely vital to demonstrate \deadNote ? (honest question:
>> if yes, fine, but please add a comment saying that it's necessary. If
>> it's not necessary, then please remove the tweak)
>>
>
> To be honest: it isn't strictly necessary, but the
> displayed string numbers are partly crossed out by the
> beams; furthermore, string numbers in combination with
> tablature is redundant. But for sake of simplicity, I removed
> the tweak.
>
> Marc
>>
>> Cheers,
>> - Graham
>>
>>
>
>
> From c98b8c2232a545d3efe45e7200816c0975dc10f1 Mon Sep 17 00:00:00 2001
> From: Marc Hohl <m...@hohlart.de>
> Date: Tue, 30 Mar 2010 22:41:10 +0200
> Subject: [PATCH] Issue 1046: Documenting
> \deadNote|\deadNotesOn|\deadNotesOff
>
> ---
> Documentation/notation/fretted-strings.itely | 25
> +++++++++++++++++++++++--
> Documentation/notation/pitches.itely | 7 ++++++-
> 2 files changed, 29 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/notation/fretted-strings.itely
> b/Documentation/notation/fretted-strings.itely
> index 0ef0d10..a39a809 100644
> --- a/Documentation/notation/fretted-strings.itely
> +++ b/Documentation/notation/fretted-strings.itely
> @@ -1470,13 +1470,34 @@ text markup.
> �...@lilypond[quote,ragged-right,verbatim]
> \relative c' {
> \clef "treble_8"
> - \override Staff.NoteHead #'style = #'cross
> - g8 a b c b4
> \override Staff.NoteHead #'style = #'harmonic-mixed
> d^\markup { \italic { \fontsize #-2 { "harm. 12" }}} <g b>1
> }
> �...@end lilypond
>
> +Dampened notes (also called @notation{dead notes}) are supported
> +within normal and tablature staves:
> +
> +...@lilypond[quote,ragged-right,verbatim]
> +music = \relative c' {
> + < a\3 \deadNote c\2 a'\1 >4
> + < b\3 \deadNote d\2 b'\1 >4
> + < c\3 \deadNote e\2 c'\1 >8
> + \deadNotesOn
> + \times 2/3 { g16\3 b\2 e\1 }
> + \deadNotesOff
> + < a,\3 c\2 e\1 >4
> +}
> +\new StaffGroup <<
> + \new Staff {
> + \clef "treble_8"
> + \music
> + }
> + \new TabStaff {
> + \music
> + }
> +>>
> +...@end lilypond
>
> �...@seealso
> Snippets:
> diff --git a/Documentation/notation/pitches.itely
> b/Documentation/notation/pitches.itely
> index 8bb544a..31af761 100644
> --- a/Documentation/notation/pitches.itely
> +++ b/Documentation/notation/pitches.itely
> @@ -2574,6 +2574,10 @@ c4 b
> c b < g \xNote c f > b
> �...@end lilypond
>
> +As synonyms for @code{\xNote}, @code{\xNotesOn} and @code{\xNotesOff},
> +...@code{\deadnote}, @code{\deadNotesOn} and @code{\deadNotesOff} can
> +be used. The term @notation{dead note} is commonly used by guitarists.
> +
> There is also a shorthand for diamond shapes which can be used
> only inside chords:
>
> @@ -2594,7 +2598,8 @@ Snippets:
>
> Notation Reference:
> �...@ref{note head styles},
> -...@ref{chorded notes}.
> +...@ref{chorded notes},
> +...@ref{indicating harmonics and dampened notes}.
>
> Internals Reference:
> �...@rinternals{note-event},
> --
> 1.5.4.3
>
>
>
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
