Hi Reinhold, LGTM.
You need to check your indentation in parser.yy, since you're adding spaces instead of hard tabs. Cheers, Neil http://codereview.appspot.com/475041/diff/1/5 File input/regression/hara-kiri-keep-previous-settings.ly (right): http://codereview.appspot.com/475041/diff/1/5#newcode33 input/regression/hara-kiri-keep-previous-settings.ly:33: % New \RemoveEmptyStaves settings: Will erase previous settings... Preserves previous settings http://codereview.appspot.com/475041/diff/1/10 File lily/context-mod.cc (right): http://codereview.appspot.com/475041/diff/1/10#newcode69 lily/context-mod.cc:69: add_context_mod (scm_car (m)); indent http://codereview.appspot.com/475041/diff/1/10#newcode73 lily/context-mod.cc:73: Context_mod::to_alist () const I'd name this something like get_mods (), otherwise it implies you're building an alist to return (which obviously isn't the case) http://codereview.appspot.com/475041/diff/1/11 File lily/include/context-mod.hh (right): http://codereview.appspot.com/475041/diff/1/11#newcode22 lily/include/context-mod.hh:22: * Implement a structore to store context modifications to be inserted structure http://codereview.appspot.com/475041/diff/1/11#newcode30 lily/include/context-mod.hh:30: // #include "lily-proto.hh" Add prototype for Context_mod to lily-proto.hh ? http://codereview.appspot.com/475041/diff/1/11#newcode49 lily/include/context-mod.hh:49: VIRTUAL_COPY_CONSTRUCTOR(Context_mod, Context_mod); VIRTUAL_COPY_CONSTRUCTOR ( http://codereview.appspot.com/475041/diff/1/12 File lily/lily-lexer.cc (right): http://codereview.appspot.com/475041/diff/1/12#newcode52 lily/lily-lexer.cc:52: {"contextModifications", CONTEXT_MOD}, contextmodifications (all the parser keywords are lower case) http://codereview.appspot.com/475041/show _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
