Reviewers: Patrick McCarty,
Message:
On 2010/02/21 21:09:54, Patrick McCarty wrote:
Is the 'after-line-breaking callback for BarNumber necessary?
I'm not quite sure; though it's unlikely anbody's going to change the
BarNumber stencil to a tall column (which would need the callback to
prevent it running off the top of the page), the regression tests seems
to depend on the callback: if you remove it, rehearsal marks, volte and
metronome marks are placed too far from staves.
Description:
Fix #943 (input/regression/slur-broken-trend.ly broken)
* move after-line-breaking processing back into System::post_processing
()
Please review this at http://codereview.appspot.com/203054/show
Affected files:
M lily/system.cc
Index: lily/system.cc
diff --git a/lily/system.cc b/lily/system.cc
index
1be38ea570ab8520b531eb6ff02a9eee032fdbba..c6257c7d310ef7bc1c0de7816a374a91492d0973
100644
--- a/lily/system.cc
+++ b/lily/system.cc
@@ -185,12 +185,6 @@ System::do_break_substitution_and_fixup_refpoints ()
{
System *child = dynamic_cast<System*> (broken_intos_[i]);
child->all_elements_->remove_duplicates ();
- for (vsize j = 0; j < child->all_elements_->size (); j++)
- {
- Grob *g = child->all_elements_->grob (j);
-
- (void) g->get_property ("after-line-breaking");
- }
}
if (be_verbose_global)
@@ -314,6 +308,13 @@ System::pre_processing ()
void
System::post_processing ()
{
+ for (vsize j = 0; j < all_elements_->size (); j++)
+ {
+ Grob *g = all_elements_->grob (j);
+
+ (void) g->get_property ("after-line-breaking");
+ }
+
Interval iv (extent (this, Y_AXIS));
if (iv.is_empty ())
programming_error ("system with empty extent");
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
