On 9/2/09 9:50 AM, "Trevor Daniels" <t.dani...@treda.co.uk> wrote:

> 
> 
> Carl Sorensen wrote Wednesday, September 02, 2009 1:06 PM
> 
>> On 9/2/09 2:41 AM, "Trevor Daniels" <t.dani...@treda.co.uk> wrote:
>>> 
>>> So instead I propose to change the definition
>>> of \fermataMarkup to:
>>> 
>>> fermataMarkup =
>>> #(make-music 'MultiMeasureTextEvent
>>>    'tweaks (list
>>>              ; Set the 'text based on the 'direction
>>>              (cons 'text (lambda (grob)
>>>                (if (eq? (ly:grob-property grob 'direction) DOWN)
>>>                  (markup #:musicglyph "scripts.dfermata")
>>>                  (markup #:musicglyph "scripts.ufermata"))))
>>>              (cons 'outside-staff-priority 40)))
>>> 
>>> Carl, as my first frogs task could you please
>>> check this out before I commit?
>> 
>> This looks good to me, but before I would approve it I would want
>> to see a
>> regtest and the output of the regtest.  Have you made a test and
>> run it?
> 
> Draft regtest and pdf output attached.
> (The function definition would be removed
> from the regtest before committing of
> course.)

LGTM.  If nobody else has comments, go ahead and push.

Thanks,

Carl



_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to