I'm going away for carnival, but reviewed 2 patches for you.
On Fri, Feb 20, 2009 at 7:36 AM, Reinhold Kainhofer <reinh...@kainhofer.com> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Apparently, my message got lost somewhere in the mail flood of lily-devel, so > I'm reposting my request for review of several patches: > Any objections to applying these patches (those with a convert-ly rule of > course only after 2.13 has been opened)? > http://codereview.appspot.com/8686 > http://codereview.appspot.com/11044 > http://codereview.appspot.com/12660 > http://codereview.appspot.com/12862 > http://codereview.appspot.com/12661 > > Cheers, > Reinhold > > On Samstag, 31. Januar 2009 00:49:47 Reinhold Kainhofer wrote: >> On Donnerstag, 18. Dezember 2008 15:45:28 Han-Wen Nienhuys wrote: >> > Can you put your timesig code into a .scm (or .ly) file ? We should >> > try to minimize nested code (ie code in language A inside code of >> > language B). >> >> Okay, finally here are some patches to include the extra functionality >> implemented for musicxml2ly directly in lilypond. >> Please review! >> >> > On Sun, Dec 28, 2008 at 1:43 PM, Reinhold Kainhofer wrote: >> >> [...] >> >> > > - -) \eyeglasses markup: >> > > http://lsr.dsi.unimi.it/LSR/Item?id=435 >> >> Patch for \eyeglasses markup command in lilypond: >> http://codereview.appspot.com/12660 >> >> > > - -) \snappizzicato markup (Bartók pizzicato, should actually be an >> > > articulation): >> > > http://lsr.dsi.unimi.it/LSR/Item?id=335 >> >> Patch to add the glyph to the feta font and define a corresponding >> \snappizzicato articulation: >> http://codereview.appspot.com/12862 >> >> > > - -) Tuplet numbers including note durations: >> > > http://lsr.dsi.unimi.it/LSR/Item?id=482 >> >> This patch adds formatting functions to >> -) Print tuplet numbers/fractions other than the values assigned >> -) Add one base duration to the number/fraction >> -) Add a duration to both the numerator and the denominator >> >> http://codereview.appspot.com/12661 >> >> > > -) Complex compound time signatures (they take up most of the code). >> >> That's not yet finished, since it needs some more polishing. Non-standard >> time-signatures are a frequently requested features, so I'd like to get the >> really correct before submitting a patch. My current issue is the question >> whether the current time sig fraction should be extended to a (nested) list >> containing the whole structure, of whether the fraction should be >> calculated as one fraction and its actual structure should be stored >> somewhere else only for display (e.g. for a time sig of 1/4+(2+3)/8, should >> I store this structure in the grob instead of the current fraction, or >> shall I assign 7/8 as the time sig fraction and store the exact >> mathematical structure only for display)? >> >> > > Ideally, all of them would be implemented directly in stock lilypond. >> > > Do you think that any of these should be moved to lilypond's .scm >> > > files? >> > >> > I think all of them could be inside lilypond. >> >> I added regtests for all of them (and a snippet for the docs for the tuplet >> number formatting functions). The PDFs generated from these files can be >> found at: >> http://www.fam.tuwien.ac.at/~reinhold/temp/lilypond_features/ >> >> Cheers, >> Reinhold > > - -- > - ------------------------------------------------------------------ > Reinhold Kainhofer, reinh...@kainhofer.com, http://reinhold.kainhofer.com/ > * Financial & Actuarial Math., Vienna Univ. of Technology, Austria > * http://www.fam.tuwien.ac.at/, DVR: 0005886 > * LilyPond, Music typesetting, http://www.lilypond.org > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.9 (GNU/Linux) > > iD8DBQFJnoe7TqjEwhXvPN0RApCSAJ9fQ4YYd+ktjnHiQ6ZOIzL4pP23wACgzrEj > 3TM1FuV1qxnpu8rq9K5FyeY= > =/Nm2 > -----END PGP SIGNATURE----- > -- Han-Wen Nienhuys - han...@xs4all.nl - http://www.xs4all.nl/~hanwen _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
