-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am Mittwoch, 10. September 2008 schrieb [EMAIL PROTECTED]: > http://codereview.appspot.com/5060/diff/201/204#newcode309 > Line 309: LY_DEFINE (ly_stencil_rotate_absolute_coordinates, > "ly:stencil-rotate-absolute-coordinates", > in the interest of brevity, you could drop 'coordinates' from the name.
Okay, will do. "absolute rotation" doesn't make sense anyway, so its clear that absolute refers to corrdinates rather than the angle... > http://codereview.appspot.com/5060/diff/201/205 > File lily/stencil.cc (right): > > http://codereview.appspot.com/5060/diff/201/205#newcode98 > Line 98: expr_, SCM_UNDEFINED); > in effect, this copies the underlying expression. It might be a little > bit nicer to mirror this in the api, ie. make a > > Stencil::rotated() > > and have Stencil::rotate be an abbrev of > > *this = rotated() Hmm, okay, I added a TODO comment in the code, but didn't implement that myself. > http://codereview.appspot.com/5060/diff/201/205#newcode127 > Line 127: // const Offset cen = Offset (extent (X_AXIS).center (), > extent (Y_AXIS).center ()); > can you remove debug code? Oops, of course. That was the old code, which I didn't remove completely... Cheers Reinhold - -- - ------------------------------------------------------------------ Reinhold Kainhofer, Vienna University of Technology, Austria email: [EMAIL PROTECTED], http://reinhold.kainhofer.com/ * Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at/ * K Desktop Environment, http://www.kde.org, KOrganizer maintainer * Chorvereinigung "Jung-Wien", http://www.jung-wien.at/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFIx/vZTqjEwhXvPN0RAvhlAJ4o8bzMZq2qtbgWBXdyjWtz0c2R5ACgsLab hFTRtPIXx0QYq7tr5hjdzZk= =vOXC -----END PGP SIGNATURE----- _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
