Attached is a patch to fix importing minor key signatures from MusicXML.
Now musicxml2ly correctly reads the minor mode (yesterday's patch), but
today I realized the circle of fifths calculation was off (this never
mattered before because minor key weren't getting imported anyway). Plus,
a value was getting initialized twice.
--Phil Kirlin
? patch
Index: scripts/musicxml2ly.py
===================================================================
RCS file: /sources/lilypond/lilypond/scripts/musicxml2ly.py,v
retrieving revision 1.19
diff -u -r1.19 musicxml2ly.py
--- scripts/musicxml2ly.py 24 Jul 2006 12:28:53 -0000 1.19
+++ scripts/musicxml2ly.py 25 Aug 2006 16:35:23 -0000
@@ -110,7 +110,7 @@
try:
(n,a) = {
'major' : (0,0),
- 'minor' : (6,0),
+ 'minor' : (5,0),
}[mode]
start_pitch.step = n
start_pitch.alteration = a
@@ -124,7 +124,6 @@
fifth.step *= -1
fifth.normalize ()
- start_pitch = musicexp.Pitch()
for x in range (fifths):
start_pitch = start_pitch.transposed (fifth)
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
