---------------------------------------- > Date: Thu, 10 Oct 2013 15:51:36 +0200 > Subject: Re: Perl's Win32::API on MSYS > From: sschube...@gmail.com > To: bul...@hotmail.com > CC: d...@perl.it; libwin32@perl.org > > On Tue, Oct 8, 2013 at 12:26 PM, bulk 88 <bul...@hotmail.com> wrote: > >> Changed the design in a branch >> https://github.com/bulk88/perl5-win32-api/tree/msys > > I've checked out your "msys" branch and your commit at [1] seems to > have fixed the MSYS build issues for me, "perl Makefile.PL && make" > produces API.dll and Callback.dll just fine now. As this solution is > much nicer than mine in the commit at [2], I'll split out the substr > length fix to a separate pull request [3] and delete my original one > at [4]. > > @bulk88, any idea when your "msys" branch will be merged to cosimo's repo? > > [1] > https://github.com/bulk88/perl5-win32-api/commit/3ef519b70431eef01859f859b8a7c4ea3a457f3c > [2] > https://github.com/sschuberth/perl5-win32-api/commit/f9fb2c599e5d9ae244be8fb4e971d57a13c0d38d > [3] https://github.com/cosimo/perl5-win32-api/pull/11 > [4] https://github.com/cosimo/perl5-win32-api/pull/10 > > -- > Sebastian Schuberth
Is https://github.com/cosimo/perl5-win32-api/pull/11 a bug fix or just code cleanup/refactor? I think it is just cleanup for prettyness. In regards to #11, do you want your commit under your name or not in git? I don't care too much so its upto you. I plan to squash 3ef519b70431eef01859f859b8a7c4ea3a457f3c "remove "package ExtUtils::MM_Win32;" uses" onto the previous commit 865055254afb2161b0dc634fb11779fbecb15d0d "old < ~6.25 MakeMakers made a bad makefile, Changes update for contribs". collapse your pull #11 commit onto those 2 and give you just changes file credit, or keep it a separate commit? Merging to cosimo's repo isn't very important. He takes many weeks historically to do it. It doesn't matter because both of use are COMAINT on CPAN so both us can release a new Win32::API whenever we want. Currently there is alot of experimental code related to performance in 0.76 alpha series. I haven't decided how much of it to keep. I also am very slowly working on __fastcall/__thiscall support on x86-32. It is very complicated, because int add4things( double one, double two, int three, __int64 four, int five, int six) in asm/machine code is actually called like int add4things( int three, int five, double one, double two, __int64 four, int six) args three and five go into ecx/edx, all other 4 byte args go on stack, which means the SV stack/@_ are now to keep things sane has to be shifted around with per element offsets to make the later ecx/edx destined args be first in the APIPARAM array. So basically, when you respond, I'll squash the commits, then have cosimo merge it. Do you require a CPAN release or can you live with a github checkout?
