Wed Feb 06 23:28:10 2013: Request 82611 was acted upon.
Transaction: Correspondence added by BULKDD
       Queue: Win32-API
     Subject: make tool detection broken in Win32::API
   Broken in: 0.74, 0.75
    Severity: Normal
       Owner: Nobody
  Requestors: bul...@cpan.org
      Status: open
 Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=82611 >


On Mon Feb 04 01:43:52 2013, BULKDD wrote:
> On Tue Jan 22 14:41:02 2013, BULKDD wrote:
> > 
> > After discussion with Mithaldu/smoker owner above, {MAKE} is
> > 'C:\Perl\site\bin\dmake.exe', not 'dmake.exe' on his machine.
> > MM_Win32.pm has a is_make_type method which uses a more elaborate RE to
> > do it. Using is_make_type will probably be the solution. Remaining
> > issues are, is_make_type is not public API of EUMM (embedding the RE is
> > the alternative), and testing the whole thing on VC Perl, S Perl and Cyg
> > Perl.
> 
> Also remove the Encode:: dependency in makefile.pl, add a dependency on
> Encode::compat, on 5.8 and newer on Win32 Encode::compat passes,
> http://www.cpantesters.org/distro/E/Encode-compat.html . So this might
> have Perl 5.6 reports show up in cpantesters for Win32::API. Also add 
> skipping the native threads with API::Callback threads test that crashes
> on 5.6.


Also improve the POD for how to pass NULL, in pack letter mode (NOT
prototype mode) for a 'P'. In prototype mode undef is NULL, but in
letter mode, 0 is NULL. There is live code (irc conversation) that uses
letter mode 0 for NULL. so dont break back compat  see this old ::API
https://github.com/bulk88/perl5-win32-api/blob/067439edfd8fab5bc7f18f5bfb16fe7ff7a75259
/API.xs#L324

Reply via email to