On 11/15/2012 09:53 PM, Osier Yang wrote: > On 2012年11月16日 08:49, Eric Blake wrote: >> For disk snapshots, the user could request an external snapshot >> but not supply a filename; later on, we would check this condition >> and generate a suitable name if possible, or gracefully error out >> when not possible (such as when the original file was a block >> device). But unless we come up with a suitable way to generate >> external memory file names, we have no later code point that was >> checking for NULL, so we should forbid this up front. >> >> * src/conf/snapshot_conf.c (virDomainSnapshotDefParseString): >> Avoid NULL deref, since we don't generate names yet. >> --- >> src/conf/snapshot_conf.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >>
> > ACK. Thanks; pushed. -- Eric Blake [email protected] +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
