On 1/9/19 11:55 AM, Michal Privoznik wrote: [...] > > > ACK > Thanks for the review... although it seems I'll have to consider a 3rd approach as a result of Daniel's comments. Nothing is ever easy. > My only worry is that we don't validate the options in any way. They are > basically a text free form which we will put onto 'mount' cmd line directly. > I thought about making sure of specific chars for the attributes (there are some examples in other .rng files), but I know as soon as I do, there's some request for some char that wasn't included. Going with <text/> was just the bail out especially since I find regex's to be unintelligible to fully decipher. John -- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
- Re: [libvirt] [PATCH v2 1/6] conf: Intro... Daniel P . Berrangé
- [libvirt] [PATCH v2 4/6] storage: Add NFS storage poo... John Ferlan
- [libvirt] [PATCH v2 2/6] nfs: Add infrastructure to m... John Ferlan
- Re: [libvirt] [PATCH v2 2/6] nfs: Add infrastruc... Michal Privoznik
- [libvirt] [PATCH v2 6/6] rbd: Utilize storage pool na... John Ferlan
- Re: [libvirt] [PATCH v2 6/6] rbd: Utilize storag... Michal Privoznik
- [libvirt] [PATCH v2 5/6] virsh: Add source-mount-opts... John Ferlan
- [libvirt] [PATCH v2 3/6] docs, tests: Add schema, des... John Ferlan
- Re: [libvirt] [PATCH v2 3/6] docs, tests: Add sc... Michal Privoznik
- Re: [libvirt] [PATCH v2 0/6] Allow adding mountOpts t... Michal Privoznik
- Re: [libvirt] [PATCH v2 0/6] Allow adding mountO... John Ferlan
- Re: [libvirt] [PATCH v2 0/6] Allow adding mountOpts t... Daniel P . Berrangé
- Re: [libvirt] [PATCH v2 0/6] Allow adding mountO... John Ferlan
- Re: [libvirt] [PATCH v2 0/6] Allow adding mo... Daniel P . Berrangé
- Re: [libvirt] [PATCH v2 0/6] Allow addin... John Ferlan
- Re: [libvirt] [PATCH v2 0/6] Allow a... Daniel P . Berrangé
- Re: [libvirt] [PATCH v2 0/6] Al... John Ferlan
