Re: [libvirt] [PATCH 1/4] qemu: domain: gfx: Fix shadowing the ptr argument to graphics validation

Tue, 11 Dec 2018 15:49:13 -0800 


On 12/7/18 9:47 AM, Erik Skultety wrote:
> Since the code was never run, this stupid mistake could have only been
> spotted by an accident.
> 
> Signed-off-by: Erik Skultety <[email protected]>
> ---
>  src/qemu/qemu_domain.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 

Gah - that wasn't obvious... and it's scary the compiler was silent.

Reviewed-by: John Ferlan <[email protected]>

John

--
libvir-list mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/libvir-list






















					Reply via email to