On 03/07/2024 17:41, Shterenlikht, Anton wrote:


On 3 Jul 2024, at 15:17, Ileana Dumitrescu <ileanadumitresc...@gmail.com> wrote:

Hi Anton,

On 03/07/2024 16:40, Shterenlikht, Anton wrote:
Hello Ileana
It seems your original patch is good,

To make sure I understand, is the original patch that worked
for you the one applied here:
https://git.savannah.gnu.org/cgit/libtool.git/commit/?h=master&id=33d4b69fccbbb557c1160cc46c3d8d2f30fb8a2d

Or is it the one below:

--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@@ -4805,7 -4805,7 +4805,7 @@@ m4_if([$1], [CXX],
        _LT_TAGVAR(lt_prog_compiler_pic, $1)='-KPIC'
        _LT_TAGVAR(lt_prog_compiler_static, $1)='-static'
          ;;
--      *flang)
++      *flang* | ftn*)
          # Flang compiler.
        _LT_TAGVAR(lt_prog_compiler_wl, $1)='-Wl,'
        _LT_TAGVAR(lt_prog_compiler_pic, $1)='-fPIC'

The latter one, the patch you have originally provided in
https://lists.gnu.org/archive/html/libtool/2024-06/msg00017.html

Okay, I will apply this. You should see it in the next release!

However, as I mentioned upthread, using the master branch,
I see different line numbers:


ashterenli@NB-068 libtool % git branch
   development
   libtool-next
* master

As I mentioned before, I usually am working off of development:
  https://lists.gnu.org/archive/html/libtool/2024-06/msg00021.html

ashterenli@NB-068 libtool % git rev-parse --short HEAD
cc511550

ashterenli@NB-068 libtool % git diff
diff --git a/m4/libtool.m4 b/m4/libtool.m4
index bbf2d21f..7039747b 100644
--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@ -4706,7 +4706,7 @@ m4_if([$1], [CXX], [
         _LT_TAGVAR(lt_prog_compiler_pic, $1)='-KPIC'
         _LT_TAGVAR(lt_prog_compiler_static, $1)='-static'
          ;;
-      *flang)
+      *flang* | ftn*)
          # Flang compiler.
         _LT_TAGVAR(lt_prog_compiler_wl, $1)='-Wl,'
         _LT_TAGVAR(lt_prog_compiler_pic, $1)='-fPIC'


Thank you for your help debugging this issue!

--
Ileana Dumitrescu

GPG Public Key: FA26 CA78 4BE1 8892 7F22 B99F 6570 EA01 146F 7354

Attachment: OpenPGP_0x6570EA01146F7354.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to