Hi Tim, * Tim Rice wrote on Fri, Feb 20, 2009 at 09:29:40PM CET: > > I'm trying to understand the cmdline_wrap.at test. > I've added this patch to fix the 2 template tests that were failing > on UnixWare 7.1.4
Can you post the verbose output of the test both without and with the patch? Thanks. gmake check-local TESTSUITEFLAGS='-k "simple template test" -v -d -x' > so now the only failure is the "low max_cmd_len" test. OK, cool. > I guess I don't really know what cmdline_wrap.at is trying to acomplish. > And I'm puzzled why the "simple template test" fails inside cmdline_wrap > but not outside of it. Well, it tries to simulate a very long command line, so long that its expansion by libtool will exceed the kernel command line length limit. It does this by setting the limit very low, which libtool internally compares against. So then the wrapping code branches are exercised, which create intermediate libraries or objects. How long is the actual command line length limit on your system? If it is >1MB or unlimited, then this is unlikely to ever be a problem in practice, and you can ignore the failure. But some systems have pretty low limits. The test case tries to re-run all kinds of other tests in our testsuite (exactly those that only exercise the $LIBTOOL script), for best possible code coverage. The output of the failing/passing of the test above may help analyze the failure of the cmdline_wrap test. Thanks! Ralf _______________________________________________ http://lists.gnu.org/mailman/listinfo/libtool
