On Wed, 2008-04-16 at 23:56 +0200, Ralf Wildenhues wrote:
> * Richard Purdie wrote on Wed, Apr 16, 2008 at 07:10:54PM CEST:
> > To 'fix' the echo issue I added:
> >
> > http://svn.o-hand.com/view/poky/trunk/meta/packages/libpng/libpng-1.2.16/makefile_fix.patch?rev=4267&view=markup
> >
> > although I suspect echo = @ECHO@ might be better. I think libpng has
> > relied on old libtool behaviour which happened to export that and no
> > longer does so its a libpng bug but I'm open to more informed comments!
>
> Sorry, but your patch just hides the real bug that you're using macro
> files from Libtool 1.5.x. You will see other, more obscure bugs (but
> then again, with their nature of being obscure, you may not see them,
> but curse a lot about how broken Libtool is).
>
> Please drop the patch and get updated macros into your tree.
I am not using 1.5 macros. libtool 2.2.2 is being used, as I can see if
I grep aclocal.m4 or ltmain.sh for the libtool version.
Let me try again to explain the problem. Makefile.am contains:
$(ECHO) [EMAIL PROTECTED]@@[EMAIL PROTECTED] '{global:' > [EMAIL
PROTECTED]
$(SED) s/$$/\;/ libpng.sym >> [EMAIL PROTECTED]
$(ECHO) 'local: *; };' >> [EMAIL PROTECTED]
automake expands ECHO_C, ECHO_N, ECHO_T and lt_ECHO but not ECHO
anymore. libtool 1.5 macros happened to let ECHO be expanded but in
2.2.2 this is lt_ECHO.
Since nothing expands ECHO anymore this breaks with libtool 2.2.2.
I think that libpng is in the wrong here though and it therefore needs
to add something to the Makefile.am to cause ECHO to expand.
Cheers,
Richard
_______________________________________________
http://lists.gnu.org/mailman/listinfo/libtool
