* Aleksey Demakov wrote on Thu, Feb 14, 2008 at 12:46:25PM CET:
> On Thu, Feb 7, 2008 at 2:23 AM, Ralf Wildenhues <[EMAIL PROTECTED]> wrote:
> > > Please take a look at AC_LIBTOOL_SYS_GLOBAL_SYMBOL_PIPE in libtool.m4.
> > [...]
> >
> > > That is while finding the correct global_symbol_pipe command it uses
> > > temporary variable $ac_symprfx. I think this variable could be just
> > re-used
> > > to tell if the system requires underscore. There is no need for a
> > separate
> > > test that relies on a gcc feature. The existing test goes through the
> > > entire chain compiler/linker/NM and therefore should be more reliable.
> >
> > I agree.
>
> Um, may it be that simple? It works for me.
Thanks for the patch. Unfortunately, you have cut the important part of
my reply:
>>Can we see testsuite output for Libtool 2.1b (see README) for a system
>>that needs a change here? This failure should be exposed already. Esp.
>>the stresstest should expose most use cases here.
I disagree with applying the patch unless you show that it improves
testsuite results. And also I want to know about other failures.
So please show results before/after the patch. Thanks.
Cheers,
Ralf
> diff -u libtool-1.5.26.orig/libtool.m4 libtool-1.5.26/libtool.m4
> --- libtool-1.5.26.orig/libtool.m4 2008-02-01 22:26:47.000000000 +0600
> +++ libtool-1.5.26/libtool.m4 2008-02-14 03:19:17.000000000 +0600
> @@ -5782,7 +5782,7 @@
>
> if test $supports_anon_versioning = yes; then
> _LT_AC_TAGVAR(archive_expsym_cmds, $1)='$echo "{ global:" >
> $output_objdir/$libname.ver~
> - cat $export_symbols | sed -e "s/\(.*\)/\1;/" >>
> $output_objdir/$libname.ver~
> + cat $export_symbols | sed -e "s/\(.*\)/'"$ac_symprfx"'\1;/" >>
> $output_objdir/$libname.ver~
> $echo "local: *; };" >> $output_objdir/$libname.ver~
> $CC '"$tmp_sharedflag""$tmp_addflag"' $libobjs $deplibs
> $compiler_flags ${wl}-soname $wl$soname ${wl}-version-script
> ${wl}$output_objdir/$libname.ver -o $lib'
> fi
>
_______________________________________________
http://lists.gnu.org/mailman/listinfo/libtool
