I would clearly vote for it. :D
I think that any project that uses AM+LT for compiling multi-threaded applications that uses any of those flags will fail to link properly, right? And these flags (-pthread, -mt, etc.) are typically the recommended method of compiling / linking multi-threaded applications.
So I'd say that it's probably a pretty big problem. :-\
On Feb 7, 2005, at 11:01 PM, Peter O'Gorman wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Jeff Squyres wrote: | | From here, I get lots of [expected] messages about missing pthread | symbols. This is somewhat of a Big Problem; it did not happen with | 1.5.10 -- meaning that -pthead was passed down to the final link in | (ditto for LT <1.5.10 that I can remember). | | What happened? |
I broke it :(
I applied the attached patch to the branch last night. The ltmain.in bit
should apply to your ltmain.sh too.
Opinions on how badly broken this is are welcome, perhaps I need to release
a 1.5.14? :((
Peter - -- Peter O'Gorman - http://www.pogma.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (Darwin)
iQCVAwUBQgg5fLiDAg3OZTLPAQKvpgP+Kwk7tSTDicU5k7fd0NUgNAqmqUUNeTux lbY02iohCZJyXoUOSc1b96N+kl7JQo1eMUsTX9RUV+hViXKc6BlUpWhy58OsDGMl TdQ0B4izFqz2d7RLP1q5iTvXe3UKHsfzyGHl+z0f0A/lO2ECN8i8rdhlUOfDJMuN RsXSPOpnD/I= =bLom -----END PGP SIGNATURE----- Index: ChangeLog 2005-02-07 Peter O'Gorman <[EMAIL PROTECTED]>
* ltmain.in: Add -pthread like flags when linking executables too. Reported by Andreas Schwab <[EMAIL PROTECTED]>
Index: ltmain.in =================================================================== RCS file: /cvsroot/libtool/libtool/Attic/ltmain.in,v retrieving revision 1.334.2.60 diff -u -3 -p -u -r1.334.2.60 ltmain.in --- ltmain.in 5 Feb 2005 13:59:47 -0000 1.334.2.60 +++ ltmain.in 7 Feb 2005 14:02:09 -0000 @@ -1525,6 +1525,8 @@ EOF
-mt|-mthreads|-kthread|-Kthread|-pthread|-pthreads|--thread-safe) compiler_flags="$compiler_flags $arg" + compile_command="$compile_command $arg" + finalize_command="$finalize_command $arg" continue ;;
-- {+} Jeff Squyres {+} [EMAIL PROTECTED] {+} http://www.lam-mpi.org/
_______________________________________________ http://lists.gnu.org/mailman/listinfo/libtool
