On 2004-08-12T09:00+0900, Peter O'Gorman wrote:
) Daniel Reed wrote:
) > On 2004-08-11T10:06+0900, Peter O'Gorman wrote:
) > ) Daniel Reed wrote:
) > ) > > libtool-1.4.2-demo.patch (on x86_64 s390 s390x)
) > ) > Yes, this is just to disable several nopic tests: afaicr nopic is
) > ) > meaningless on those archs bicbw... ie a patch should really go upstream
) > ) > to skip those tests on those archs I guess.
) > ) Well, if you can be bothered to make a real patch, we might look at it. A
) > ) patch that simply removes tests from the Makefile.am is not a good thing[tm] :).
) > tests/demo-nopic.test already skips itself if `config.guess` begins with
) > "hppa"; should I just extend that check to skip x86_64 and s390?
With this patch, libtool's make check passes on an x86_64 test machine.
Without it, the demo-make after demo-nopic generates a failure:
...
| gcc -shared .libs/hello.o .libs/foo.o -lm -Wl,-soname -Wl,libhello.so.2 -o
.libs/libhello.so.2.1.12
| /usr/bin/ld: .libs/hello.o: relocation R_X86_64_32 can not be used when making a
shared object; recompile with -fPIC
| .libs/hello.o: could not read symbols: Bad value
| collect2: ld returned 1 exit status
| make[3]: *** [libhello.la] Error 1
| make[3]: Leaving directory `/tmp/libtool-1.5.8/demo'
| FAIL: demo-make.test
--
Daniel Reed <[EMAIL PROTECTED]> http://people.redhat.com/djr/ http://naim.n.ml.org/
"A professor is one who talks in someone else's sleep."
diff -rcN libtool,orig/ChangeLog libtool/ChangeLog
*** libtool,orig/ChangeLog 2004-08-07 10:03:38.000000000 -0400
--- libtool/ChangeLog 2004-08-11 21:08:15.462531000 -0400
***************
*** 1,3 ****
--- 1,7 ----
+ 2004-08-11 Daniel Reed <[EMAIL PROTECTED]>
+
+ * tests/demo-nopic.test: Do not run on x86_64 or s390*
+
2004-08-07 Peter O'Gorman <[EMAIL PROTECTED]>
* configure.ac: Bumped version to 1.5.9a.
diff -rcN libtool,orig/tests/demo-nopic.test libtool/tests/demo-nopic.test
*** libtool,orig/tests/demo-nopic.test 2004-01-23 01:03:32.000000000 -0500
--- libtool/tests/demo-nopic.test 2004-08-11 20:52:32.736643000 -0400
***************
*** 13,20 ****
# This doesn't work on hppa
HOST=`../config.guess`
case "$HOST" in
! hppa*)
! echo "Not running on hppa, it doesn't like non-PIC shared libs" 2>&1
exit 77
esac
--- 13,20 ----
# This doesn't work on hppa
HOST=`../config.guess`
case "$HOST" in
! hppa*|x86_64*|s390*)
! echo "Not running on $HOST, it doesn't like non-PIC shared libs" 2>&1
exit 77
esac
_______________________________________________
Libtool mailing list
[EMAIL PROTECTED]
http://lists.gnu.org/mailman/listinfo/libtool
