Bob, I agree, and would approve such a patch if one were posted.
Robert -----Original Message----- From: Bob Friesenhahn [mailto:[EMAIL PROTECTED] Sent: Monday, September 15, 2003 1:38 PM To: Boehne, Robert Cc: Dalibor Topic; [EMAIL PROTECTED] Subject: RE: Fixing malloc.h related warning On Mon, 15 Sep 2003, Boehne, Robert wrote: > Dalibor, > > Ok, I checked that both headers are checked for, and they are, so > the only unresolved issue would be if some platform needed both > headers. Does anyone out there know one way or the other? I suggest implementing this change, and we will find out soon enough if we guessed wrong. If there is doubt, then it is best to side with the standards. None of the platforms I build software on fail to provide a fully functional stdlib.h. Bob > -----Original Message----- > From: Dalibor Topic [mailto:[EMAIL PROTECTED] > Sent: Monday, September 15, 2003 1:10 PM > To: Boehne, Robert > Cc: [EMAIL PROTECTED] > Subject: Re: Fixing malloc.h related warning > > > Hi Robert, > > what about > > /* > * Include the header defining malloc. > * > * On K&R C compilers, that's <malloc.h>, > * on ANSI C and ISO C compilers, that's > * <stdlib.h>. > * > */ > #if HAVE_STDLIB_H > # include <stdlib.h> > #else > # if HAVE_MALLOC_H > # include <malloc.h> > # endif > #endif > > > cheers, > dalibor topic > > Boehne, Robert wrote: > > Dalibor, > > > > This would require a patch that looks for whatever malloc.h is #included for > > in stdlib.h and prefers it in stdlib.h. So it isn't as simple as s/malloc/stdlib/. > > > > Robert > > > > > > -----Original Message----- > > From: Dalibor Topic [mailto:[EMAIL PROTECTED] > > Sent: Monday, September 15, 2003 11:36 AM > > To: Libtool mailing list > > Subject: Fixing malloc.h related warning > > > > > > Hi, > > > > bulding code that uses libtool 1.5 on i386-FreeBSD 4.8, I noticed a > > compiler warning: > > > > gcc -DHAVE_CONFIG_H -I. -I../../kaffe-1.1.1/libltdl -I. -g -O2 -c > > ../../kaffe-1.1.1/libltdl/ltdl.c -fPIC -DPIC -o .libs/ltdl.o > > In file included from ../../kaffe-1.1.1/libltdl/ltdl.c:57: > > /usr/include/malloc.h:2: warning: #warning "this file includes > > <malloc.h> which is deprecated, use <stdlib.h> instead" > > > > Could the offending include be removed from source of ltdl.c? > > > > cheers, > > dalibor topic > > > > > > > > _______________________________________________ > > Libtool mailing list > > [EMAIL PROTECTED] > > http://mail.gnu.org/mailman/listinfo/libtool > > > > > _______________________________________________ > Libtool mailing list > [EMAIL PROTECTED] > http://mail.gnu.org/mailman/listinfo/libtool > ====================================== Bob Friesenhahn [EMAIL PROTECTED] http://www.simplesystems.org/users/bfriesen _______________________________________________ Libtool mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/libtool