> Version type = linux has been used in libtool for a long time, changing it is
> pointless, not in any way called for by the GNU coding standards,

I understand that the value "linux" of the variable "version_type" is
acceptable according to the GNU coding standards. I think the documentation
would have been more consistent with the value "gnu-linux" though.

> and will likely lead to bugs.

Definitely.

I have attached to this mail an updated version of my previous patch.

Christophe
diff -Naur libtool.orig/doc/libtool.texi libtool.new/doc/libtool.texi
--- libtool.orig/doc/libtool.texi	2011-08-31 21:50:53.000000000 +0200
+++ libtool.new/doc/libtool.texi	2011-09-04 12:30:18.000000000 +0200
@@ -3784,7 +3784,7 @@
 
 @itemize @bullet
 @item
-@code{dlopen} (Solaris, Linux and various BSD flavors)
+@code{dlopen} (Solaris, GNU/Linux and various BSD flavors)
 @item
 @code{shl_load} (HP-UX)
 @item
@@ -3823,7 +3823,7 @@
 @section How to use libltdl in your programs
 
 @noindent
-The libltdl API is similar to the dlopen interface of Solaris and Linux,
+The libltdl API is similar to the dlopen interface of Solaris and GNU/Linux,
 which is very simple but powerful.
 
 @noindent
@@ -3945,7 +3945,7 @@
 
 @item system library search path:
 The system dependent library search path
-(e.g.@: on Linux it is @env{LD_LIBRARY_PATH}).
+(e.g.@: on GNU/Linux it is @env{LD_LIBRARY_PATH}).
 @end enumerate
 
 Each search path must be a list of absolute directories separated by
@@ -5372,7 +5372,7 @@
 The @file{tests/mdemo} subdirectory contains a demonstration of a
 package that uses libtool and the system independent dlopen wrapper
 @file{libltdl} to load modules.  The library @file{libltdl} provides a
-dlopen wrapper for various platforms (Linux, Solaris, HP/UX etc.)
+dlopen wrapper for various platforms (GNU/Linux, Solaris, HP/UX etc.)
 including support for dlpreopened modules (@pxref{Dlpreopening}).
 
 The tests matching @file{mdemo-*make.test}, @file{mdemo-*exec.test},
diff -Naur libtool.orig/doc/notes.texi libtool.new/doc/notes.texi
--- libtool.orig/doc/notes.texi	2011-08-31 21:50:53.000000000 +0200
+++ libtool.new/doc/notes.texi	2011-09-04 12:25:56.000000000 +0200
@@ -68,7 +68,7 @@
 and all recent releases of XEmacs.
 
 @item
-When building on some linux systems for multilib targets
+When building on some GNU/Linux systems for multilib targets
 @command{libtool} sometimes guesses the wrong paths that the linker
 and dynamic linker search by default. If this occurs, you may override
 libtool's guesses at @command{configure} time by setting the
diff -Naur libtool.orig/libltdl/config/ltmain.m4sh libtool.new/libltdl/config/ltmain.m4sh
--- libtool.orig/libltdl/config/ltmain.m4sh	2011-08-31 21:50:53.000000000 +0200
+++ libtool.new/libltdl/config/ltmain.m4sh	2011-09-04 12:27:53.000000000 +0200
@@ -6605,7 +6605,7 @@
 	none) ;;
 
 	darwin)
-	  # Like Linux, but with the current version available in
+	  # Like GNU/Linux, but with the current version available in
 	  # verstring for coding it into the library header
 	  func_arith $current - $age
 	  major=.$func_arith_result
diff -Naur libtool.orig/libltdl/m4/libtool.m4 libtool.new/libltdl/m4/libtool.m4
--- libtool.orig/libltdl/m4/libtool.m4	2011-08-31 21:50:53.000000000 +0200
+++ libtool.new/libltdl/m4/libtool.m4	2011-09-04 12:27:36.000000000 +0200
@@ -2633,12 +2633,12 @@
   hardcode_into_libs=yes
   ;;
 
-# No shared lib support for Linux oldld, aout, or coff.
+# No shared lib support for GNU/Linux oldld, aout, or coff.
 linux*oldld* | linux*aout* | linux*coff*)
   dynamic_linker=no
   ;;
 
-# This must be Linux ELF.
+# This must be GNU/Linux ELF.
 linux* | k*bsd*-gnu | kopensolaris*-gnu)
   version_type=linux
   need_lib_prefix=no
@@ -3284,7 +3284,7 @@
   lt_cv_deplibs_check_method=pass_all
   ;;
 
-# This must be Linux ELF.
+# This must be GNU/Linux ELF.
 linux* | k*bsd*-gnu | kopensolaris*-gnu)
   lt_cv_deplibs_check_method=pass_all
   ;;
@@ -4066,7 +4066,7 @@
 	  cxx*)
 	    # Compaq C++
 	    # Make sure the PIC flag is empty.  It appears that all Alpha
-	    # Linux and Compaq Tru64 Unix objects are PIC.
+	    # GNU/Linux and Compaq Tru64 Unix objects are PIC.
 	    _LT_TAGVAR(lt_prog_compiler_pic, $1)=
 	    _LT_TAGVAR(lt_prog_compiler_static, $1)='-non_shared'
 	    ;;
@@ -4121,7 +4121,7 @@
 	    # Digital/Compaq C++
 	    _LT_TAGVAR(lt_prog_compiler_wl, $1)='-Wl,'
 	    # Make sure the PIC flag is empty.  It appears that all Alpha
-	    # Linux and Compaq Tru64 Unix objects are PIC.
+	    # GNU/Linux and Compaq Tru64 Unix objects are PIC.
 	    _LT_TAGVAR(lt_prog_compiler_pic, $1)=
 	    _LT_TAGVAR(lt_prog_compiler_static, $1)='-non_shared'
 	    ;;
diff -Naur libtool.orig/libltdl/README libtool.new/libltdl/README
--- libtool.orig/libltdl/README	2011-08-31 21:50:53.000000000 +0200
+++ libtool.new/libltdl/README	2011-09-04 12:25:56.000000000 +0200
@@ -1,7 +1,7 @@
 This is GNU libltdl, a system independent dlopen wrapper for GNU libtool.
 
 It supports the following dlopen interfaces:
-* dlopen (Solaris, Linux and various BSD flavors)
+* dlopen (Solaris, GNU/Linux and various BSD flavors)
 * shl_load (HP-UX)
 * LoadLibrary (Win16 and Win32)
 * load_add_on (BeOS)
diff -Naur libtool.orig/TODO libtool.new/TODO
--- libtool.orig/TODO	2011-08-31 21:50:53.000000000 +0200
+++ libtool.new/TODO	2011-09-04 12:25:57.000000000 +0200
@@ -58,7 +58,7 @@
 
 * Audit file listing in libtool.m4.
 
-* Fix deplibs_check_method=pass_all (which is wrong!) on linux.
+* Fix deplibs_check_method=pass_all (which is wrong!) on GNU/Linux.
 
 * Fix -dlopen "self" on AIX.  Reported by Gary Kumfert <kumf...@llnl.gov>.
 
@@ -290,15 +290,15 @@
     and central_unixish_to_mingw would still do all the work (with its guts
     customized based on $build).
 
-    For more reasonable cross environments (e.g. linux->some_embedded) I think
-    you could probably work out a general M+N scheme, since most embedded $hosts
-    aren't as strange as the win32 variants -- even VxWorks and INTEGRITY have
-    basic, unix-like file systems (although INTEGRITY does have multiple roots).
-    Aggressive use of the m4 function_replace machinery WOULD be appropriate for
-    /these/ conversion functions.  OTOH...(a) you can't run the $host apps on
-    $build anyway, in these embedded situations. At best you'd use $TARGETSHELL
-    and "run" them via a remote connection, and (b) they don't use the C
-    wrapper!
+    For more reasonable cross environments (e.g. GNU/Linux->some_embedded) I
+    think you could probably work out a general M+N scheme, since most embedded
+    $hosts aren't as strange as the win32 variants -- even VxWorks and INTEGRITY
+    have basic, unix-like file systems (although INTEGRITY does have multiple
+    roots). Aggressive use of the m4 function_replace machinery WOULD be
+    appropriate for /these/ conversion functions.  OTOH...(a) you can't run the
+    $host apps on $build anyway, in these embedded situations. At best you'd use
+    $TARGETSHELL and "run" them via a remote connection, and (b) they don't use
+    the C wrapper!
 
     So...I don't think it makes much difference *right now* in the amount of
     code required, or the number of functions implemented. At some point in the

Reply via email to