On 01/19/2011 12:38 PM, Ralf Wildenhues wrote: Hi Ralf,
Thanks for the quick review! Yes, the testsuite addition fails before the patch, and passes after.
Also,>/dev/null 2>&1 (order matters!) Are you really grepping the binary intentionally here, rather than the .err file?
Yes, and that will cause problems when cross-compiling to Mac OS X on systems without GNU grep (or an equivalent grep that greps binary files), sigh. However, I doubt that is a major issue right now.
I will push the patch with nits addressed later on today. Peter
