* Peter Rosin wrote on Fri, Sep 10, 2010 at 03:11:39PM CEST: > Den 2010-09-05 23:29 skrev Ralf Wildenhues: > > You're gonna hate me for this, I already know, but: does this patch fix > > testsuite failures, are all code paths covered? If not, we need to > > improve the test suite. If yes, please mention them in the log, thanks. > > I have been looking into this quite a bit, no hatred yet though :-)
Great, I'm relieved to hear this. :-) > The patch touches 7 $NM invocations, from the top: > > func_generate_dlsyms > -------------------- > > 1. Not covered, you'd need to link a program with -dlopen self, > but also with a non-libtool object (.o) and/or an non-libtooled old > archive (.a). Neither appears to happen in the testsuite. I don't know > why the code isn't exporting symbols from libtool objects (.lo). mdemo > and stresstest both use object.lo, so they do not trigger this code > path, but almost. So, a previous testsuite deficiency that should not > hold back this patch. Adding coverage for this added to my TODO list. Sounds like a fairly unportable endeavor though, so it's clear that it's not top priority. > 4. Probably covered by mdemo too, but you would need a setup that needs > func_to_tool_file on something that's not a Windows $host, which I don't > have access to. Hmm. We don't have such a thing ATM, right? I mean, a non-w32 $host which needs a nontrivial func_to_tool_file? > func_cygming_gnu_implib_p > ------------------------- > > 6. Dead code. Needs the sharedlib_from_linklib -> sharedlib_from_linklib_cmd > typo fix. So, a previous testsuite deficiency that should not hold back this > patch. > > > func_cygming_gnu_implib_p and func_cygming_ms_implib_p > ------------------------------------------------------ > > 7. Dead code. Needs the sharedlib_from_linklib -> sharedlib_from_linklib_cmd > typo fix. So, a previous testsuite deficiency that should not hold back this > patch. Great. > Here's an update of the patch to make use of the new lazy argument to > func_to_tool_file and documenting the testsuite exposure in ChangeLog. I > hope I don't have to verify 4. No you don't. Please commit. Thank you! Ralf > Subject: [PATCH] Convert file name to toolchain format when invoking $NM. > > * libltdl/config/ltmain.m4sh (func_generate_dlsyms) > (func_win32_libid, func_cygming_gnu_implib_p) > (func_cygming_ms_implib_p): When using the name lister to find > symbols in files, convert the file names to a format appropriate > for the tool. Fixes testsuite issues in mdemo-static-make.test > and mdemo-make.test when doing a cross from Cygwin/Wine to MinGW > using MinGW native tools (a.k.a. a "faked" cross).
