On 8/27/2010 3:47 PM, Ralf Wildenhues wrote:
> * Charles Wilson wrote on Fri, Aug 27, 2010 at 08:49:24PM CEST:
>> As I said, I don't mind rebasing. I'll probably only test the result on
>> cygwin-native, mingw-native, and linux->mingw, and then push to master.
>
> Oh that's plenty fine.
>
>> However, once I have finished the requested changes above and the
>> rebasing (plus whatever comes of the four open ***QQQ***uestions)
Ok, I've addressed all of the review comments, including the results of
the four ***QQQ***estions. Quick-N-Dirty spot testing on native cygwin,
native mingw, cygwin->mingw, linux->mingw, linux->cygwin all look good,
so I'm about to rebase on my private branch. However, to make that a
little less painful I'm going to squash all my changes that arose from
this review into a single commit first (no sense in working four times
as hard to fixup four separate commits).
Here are the log messages for the new three commits. Obviously, after
the squash, the resulting log message will look a lot like the one for
the patch as originally posted in this thread, but with a lot of the
function names changed.
This is just an FYI. The take-away here is that I did go ahead and
rename all the functions to
func_convert_{file|path}_X_to_Y
and moved them to just before func_mode_compile. I changed all comments
and function names to use the 'file' (or file name) and 'path'
terminology, instead of the original 'path' and 'pathlist' terminology.
Peter is going to hate me.
--
Chuck
commit 76dcbec9e2f61582946bdf170acaf238555eb0a1
Author: Charles Wilson <...>
Date: Sat Aug 28 02:30:06 2010 -0400
Update per review comments
* configure.ac: Ensure to_host_file_cmd is available to Makefile.
* libltdl/config/general.m4sh: Define lt_sed_naive_backslashify here.
* libltdl/config/ltmain.m4sh: Update comments throughout.
(func_convert_core_file_wine_to_w32): Move lt_sed_naive_backslashify
to general.m4sh.
(func_convert_core_path_wine_to_w32): Use shortname for oldIFS. Remove
unnecessary 'if' statement.
(func_cygpath): Fix typo.
(func_convert_core_msys_to_w32): Move lt_sed_naive_backslashify to
general.m4sh.
(func_convert_path_check): Remove unnecessary backslash.
(func_convert_path_front_back_pathsep): Remove unnecessary quotes.
(func_to_host_file): Don't use eval.
(func_convert_file_noop): Don't set $opt_debug.
(func_to_host_path): Don't use eval.
(func_convert_path_noop): Don't set $opt_debug.
(func_convert_path_msys_to_w32): Don't quote :.
(func_convert_path_cygwin_to_w32): Ditto.
(func_convert_path_nix_to_w32): Ditto.
(func_convert_path_msys_to_cygwin): Ditto.
(func_convert_path_nix_to_cygwin): Ditto.
* libltdl/m4/libtool.m4 (_LT_PATH_CONVERSION_FUNCTIONS): Update
comments. Use correct patterns in case statements. Don't AC_SUBST
to_host_file_cmd here.
commit e76d7302ec87e6c36e4c9b32c98ad2ff481b2491
Author: Charles Wilson <...>
Date: Fri Aug 27 19:22:25 2010 -0400
Rename file/path conversion functions
* TODO: Document QoI issue with file name conversion functions.
* Makefile.am (TESTS_ENVIRONMENT): Renamed cache variable
lt_cv_to_host_path_cmd to lt_cv_to_host_file_cmd; Renamed
environment variable to_host_path_cmd to to_host_file_cmd.
* tests/testsuite.at: Ditto.
* libltdl/m4/libtool.m4 (_LT_PATH_CONVERSION_FUNCTIONS): Adapt to
function renames, and shell and cache variable renames.
* libltdl/config/ltmain.m4sh: Renamed variable to_host_path_cmd
to to_host_file_cmd. Renamed variable to_host_pathlist_cmd to
to_host_path_cmd.
(func_to_host_path): Renamed to
(func_to_host_file): this.
(func_to_host_pathlist): Renamed to
(func_to_host_path): this.
(func_init_to_host_pathlist_cmd): Renamed to
(func_init_to_host_path_cmd): this. Adapt to new function name pattern.
(func_wine_to_win32_path): Renamed to
(func_convert_core_file_wine_to_w32): this.
(func_wine_to_win32_pathlist): Renamed to
(func_convert_core_path_wine_to_w32): this.
(func_msys_to_win32): Renamed to
(func_convert_core_msys_to_w32): this.
(func_path_convert_check): Renamed to
(func_convert_file_check): this.
(func_pathlist_convert_check): Renamed to
(func_convert_path_check): this.
(func_pathlist_front_back_pathsep): Renamed to
(func_convert_path_front_back_pathsep): this.
(func_noop_path_convert): Renamed to
(func_convert_file_noop): this.
(func_msys_to_mingw_path_convert): Renamed to
(func_convert_file_msys_to_w32): this.
(func_cygwin_to_mingw_path_convert): Renamed to
(func_convert_file_cygwin_to_w32): this.
(func_nix_to_mingw_path_convert): Renamed to
(func_convert_file_nix_to_w32): this.
(func_msys_to_cygwin_path_convert): Renamed to
(func_convert_file_msys_to_cygwin): this.
(func_nix_to_cygwin_path_convert): Renamed to
(func_convert_file_nix_to_cygwin): this.
(func_noop_pathlist_convert): Renamed to
(func_convert_path_noop: this.
(func_msys_to_mingw_pathlist_convert): Renamed to
(func_convert_path_msys_to_w32): this.
(func_cygwin_to_mingw_pathlist_convert): Renamed to
(func_convert_path_cygwin_to_w32): this.
(func_nix_to_mingw_pathlist_convert): Renamed to
(func_convert_path_nix_to_w32): this.
(func_msys_to_cygwin_pathlist_convert): Renamed to
(func_convert_path_msys_to_cygwin): this.
(func_nix_to_cygwin_pathlist_convert): Renamed to
(func_convert_path_nix_to_cygwin): this.
commit 4efd1da7d2ca7de9bfd9d3a4aa29a5fe80d197b2
Author: Charles Wilson <...>
Date: Fri Aug 27 16:30:25 2010 -0400
Move file/path conversion functions
libltdl/config/ltmain.m4sh (func_cygpath): Move ahead of
func_mode_compile.
(func_to_host_path, func_to_host_pathlist): Ditto.
(func_wine_to_win32_path): Ditto.
(func_msys_to_win32): Ditto.
(func_path_convert_check): Ditto.
(func_noop_path_convert): Ditto.
(func_msys_to_mingw_path_convert): Ditto.
(func_cygwin_to_mingw_path_convert): Ditto.
(func_nix_to_mingw_path_convert): Ditto.
(func_msys_to_cygwin_path_convert): Ditto.
(func_nix_to_cygwin_path_convert): Ditto.
(func_pathlist_convert_check): Ditto.
(func_pathlist_front_back_pathsep): Ditto.
(func_wine_to_win32_pathlist): Ditto.
(func_noop_pathlist_convert): Ditto.
(func_msys_to_mingw_pathlist_convert): Ditto.
(func_cygwin_to_mingw_pathlist_convert): Ditto.
(func_nix_to_mingw_pathlist_convert): Ditto.
(func_msys_to_cygwin_pathlist_convert): Ditto.
(func_nix_to_cygwin_pathlist_convert): Ditto.
