* Paolo Bonzini wrote on Tue, Aug 03, 2010 at 10:04:08AM CEST: > On 08/01/2010 12:48 PM, Ralf Wildenhues wrote: > [ other packages that already use --with-sysroot ]
> >I'm not sure how to address these (not even sure > >they use Libtool) except for a big sign in NEWS, and documentation in > >the manual. > > I can think of two ways: > > 1) ignore --with-sysroot if not cross-compiling. This however has a > problem: if we test $cross_compiling = yes, sysroot tests will fail > under Wine. Yes, both that, and: I thought this patch series was meant to be usable also for native compilation? Distro packages much like to do things like that. > 2) support both --with-sysroot and --with-host-sysroot, with the > latter overriding the first. Make GCC's toplevel always pass > --without-host-sysroot to build modules, always pass > --without-host-sysroot unless it was specified for host modules > (this serves Canadian crosses), and skip --with-host-sysroot for > target modules. This is a hack, but one that can work reliably. At this point you have me lost, simply because I can't claim to understand all the details here. So I can't give good advice. My best bet would be to either trust you, or require some way to set things up with GCC to try them out. Doesn't have to be a testsuite addition, just some recipe that works. Also, I just noticed that recent GCC can just be passed --sysroot $D and it will print $D upon --print-sysroot, so maybe if this is supported it can be used for wider test exposure? If you need GCC to support the sysroot, that is. And maybe symlink-tree will come in handy ... ? Thanks, Ralf