On 06/07/2010 03:52 PM, Peter O'Gorman wrote:

Ok spent 5 minutes with google and the selinux manpages (something I
have to do any time I do anything related to selinux).

The above is, of course, after tests/demo-nopic.test, and the problem is
the selinux boolean allow_execmod which disallows text relocations.

I'll look into making the test skip in this case.

Ok?

Peter
>From cb91e71e6913d09e20a5176e3d3591136e116bc3 Mon Sep 17 00:00:00 2001
From: Peter O'Gorman <pe...@pogma.com>
Date: Tue, 8 Jun 2010 20:07:50 -0500
Subject: [PATCH] Skip demo-nopic tests if SELinux policy will cause failure.

* tests/demo-nopic.test: Check SELinux policy and skip if
necessary.
* tests/testsuite.at (LT_AT_CONFIGURE, LT_AT_MAKE):
---
 ChangeLog             |    6 ++++++
 tests/demo-nopic.test |   13 +++++++++++++
 2 files changed, 19 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 0ce3ca0..de33f80 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2010-06-08  Peter O'Gorman  <pe...@pogma.com>
+
+	Skip demo-nopic tests if SELinux policy will cause failure.
+	* tests/demo-nopic.test: Check SELinux policy and skip if
+	necessary.
+
 2010-06-08  Ralf Wildenhues  <ralf.wildenh...@gmx.de>
 
 	Fix testsuite helper macros to not hide failure.
diff --git a/tests/demo-nopic.test b/tests/demo-nopic.test
index 11e5c16..b47f70c 100755
--- a/tests/demo-nopic.test
+++ b/tests/demo-nopic.test
@@ -34,6 +34,19 @@ hppa*|x86_64*|s390*)
 	;;
 esac
 
+if test -d "/etc/selinux"; then
+	_selinux=`getenforce 2>/dev/null || echo "Disabled"`
+	case "${_selinux}" in
+	*Enforcing)
+		_sebool_allow_execmod=`getsebool allow_execmod 2>/dev/null`
+		case "${_sebool_allow_execmod}" in
+			*off)
+				func_skip "SELinux policy disallows"
+				;;
+		esac
+	esac
+fi
+
 func_rmprefixdir
 func_cd "tests/demo"
 func_make_distclean
-- 
1.7.0.1

Reply via email to