Hi Peter, * Peter Rosin wrote on Fri, Jan 22, 2010 at 10:12:11AM CET: > As mentioned in another mail, should not lt_dlloader_add > call vtable->dlloader_init? That seems appropriate when > lt_dlloader_remove calls vtable->dlloade_exit... > > Like this (completely untested), just showing what I mean...
Yes, I think this is an improvement. It is an API change however. I think we can argue that it is a compatible change, since .dlloader_init was undocumented before, and calling it a second time needs to be a no-op (we need to fix preopen.c!). That still means both CURRENT and AGE of libltdl need a bump. Further, NEWS needs an entry, the patch should be tested on Darwin and on some system with only the preloader enabled (probably ok to just force this somewhere). Ideally, we should have a test that adds a user-written loader and exercises that, to ensure our documentation is accurate, too. (This loader can just fake all operations and never look at the file system.) I can help with stuff you're not volunteering for. Thanks, Ralf
