Hello Michael,
thanks for the bug report.
* Michael Haubenwallner wrote on Tue, Oct 28, 2008 at 04:12:40PM CET:
>
> maybe I'm just puzzled, but to me it seems there are the same two
> problems in each tests/cdemo-undef.test and tests/tagdemo-undef.test.
Yep.
> Consider this line:
> grep '^allow_undefined=.?unsupported.?$' ./libtool >/dev/null 2>&1 \
>
> 1) Shouldn't this search for "^allow_undefined_flag=.?undefined.?$"
> instead of "^allow_undefined=.?undefined.?$"
> Ehm, this should read 'unsupported', not 'undefined'.
Agreed on both counts.
> 2) The ".?" regex is not necessarily supported by non-GNU grep, it might
> not understand the '?' as expected.
Using \{0,1\} instead is portable, though.
> Both problems lead 'tagdemo-undef.test' to FAIL while it should be
> SKIPped here.
> Ehm, this makes 'tagdemo-make.test' FAILing when 'tagdemo-undef.test' is
> not SKIPped on platforms with [allow_undefined_flag="unsupported"].
"here" is on AIX?
> For 'cdemo-undef.test': It PASSes, and I haven't seen any undefined
> symbol there. What exactly is this test for?
Not sure. But since the changed setting in libtool anyway exposes a
different code path, I'm thinking of leaving the test in anyway.
> (patch attached, assuming ["] around the [unsupported] value)
Thanks!
Ralf
2008-10-28 Michael Haubenwallner <[EMAIL PROTECTED]> (tiny change)
Fix checks for unsupported allow_undefined_flag.
* tests/tagdemo-undef.test: Match allow_undefined_flag
correctly, for SKIPping.
* tests/cdemo-undef.test: Likewise.
diff --git a/tests/cdemo-undef.test b/tests/cdemo-undef.test
index f38da0d..7d5cd9b 100755
--- a/tests/cdemo-undef.test
+++ b/tests/cdemo-undef.test
@@ -1,7 +1,7 @@
#! /bin/sh
# cdemo-undef - test generating shared libraries with undefined symbols
#
-# Copyright (C) 2003, 2004 Free Software Foundation, Inc.
+# Copyright (C) 2003, 2004, 2008 Free Software Foundation, Inc.
# Written by Gary V. Vaughan, 2003
#
# This file is part of GNU Libtool.
@@ -30,7 +30,7 @@ func_cd "tests/cdemo"
func_make_distclean
func_configure "--disable-static"
-grep '^allow_undefined=.?unsupported.?$' ./libtool >/dev/null 2>&1 \
+grep '^allow_undefined_flag=.\{0,1\}unsupported.\{0,1\}$' ./libtool >/dev/null
2>&1 \
&& func_skip "$host doesn't support undefined symbols in shared libs"
if test -f ./libtool; then
diff --git a/tests/tagdemo-undef.test b/tests/tagdemo-undef.test
index e67e4cc..e1f966d 100755
--- a/tests/tagdemo-undef.test
+++ b/tests/tagdemo-undef.test
@@ -1,7 +1,7 @@
#! /bin/sh
# tagdemo-undef - test generating shared libraries with undefined symbols
#
-# Copyright (C) 2003, 2004 Free Software Foundation, Inc.
+# Copyright (C) 2003, 2004, 2008 Free Software Foundation, Inc.
# Written by Gary V. Vaughan, 2003
#
# This file is part of GNU Libtool.
@@ -31,7 +31,7 @@ func_cd "tests/tagdemo"
func_make_distclean
func_configure "--disable-static"
-grep '^allow_undefined=.?unsupported.?$' ./libtool >/dev/null 2>&1 \
+grep '^allow_undefined_flag=.\{0,1\}unsupported.\{0,1\}$' ./libtool >/dev/null
2>&1 \
&& func_skip "$host doesn't support undefined symbols in shared libs"
if test -f ./libtool; then
