Ralf Wildenhues wrote: > * Ralf Wildenhues wrote on Fri, Sep 19, 2008 at 08:59:37PM CEST: >> * Peter O'Gorman wrote on Fri, Sep 19, 2008 at 08:42:38PM CEST: >>> I have not applied the patch to check, but doesn't this just give a >>> manpage with the default --help output, and no information for the >>> various --mode options? >> Yes. And AFAICS it even breaks -h (short help) output. :-/ > > Proposed addition (to be squashed on top of previous patch, so no need > for more Makefile.am ChangeLog bits). > > OK? Do we need testsuite tests for the various help options, and if > yes, how do I check them sensibly without having to adjust the > comparison pattern constantly? > > (One minor nit against the patch is that 'func_help noexit' does not > return any error status that the output may have created. But it is > late now, no call site of func_help cares so far, and me neither...) > > Thanks, > Ralf
This looks ok to me, thank you. Peter -- Peter O'Gorman http://pogma.com
