[ <http://lists.gnu.org/archive/html/libtool-patches/2008-04/msg00096.html> ]
Hello Bob, Roland,
* Bob Friesenhahn wrote on Sat, Apr 19, 2008 at 05:13:13PM CEST:
> On Sat, 19 Apr 2008, Ralf Wildenhues wrote:
>
>> Let's reuse at_func_arith from Autotest, to redo one of the link mode
>> speedups that fell under the cracks a couple of years ago.
>>
>> IIRC somebody else suggested this recently, but I don't remember who.
>> Please speak up so I can put your name in the ChangeLog entry.
>
> Roland Mainz <[EMAIL PROTECTED]> (OpenSolaris/Ksh93 guy) is the
> suitable party to blame.
Thanks, Cc:ed.
>> OK to apply?
> I do not see anything wrong with the patch. Please apply it.
Thanks for the quick review. Applied and pushed, I've put Roland in
THANKS.
Cheers,
Ralf
2008-04-19 Ralf Wildenhues <[EMAIL PROTECTED]>
Exploit shell arithmetic expansion and ${#var}.
* libltdl/m4/libtool.m4 (_LT_CHECK_SHELL_FEATURES): Also check
for arithmetic expansion, and ${#var}.
(_LT_PROG_XSI_SHELLFNS): Define func_arith and func_len
accordingly, falling back on 'expr'. Note that the argument to
func_len may not start with a hyphen. In the pre-Posix
fallback, take care not to rely on the exit status of the
variable assignment (not portable), but set the length to
$max_cmd_len instead.
* libltdl/config/ltmain.m4sh (func_mode_link): Use func_arith
and func_len throughout for integer arithmetic, fixing
quadratical amount of counting for reloadable object and
piecewise archive linking. Change all comparisons with
max_cmd_len to test for smaller, non-equal length.
* THANKS: Update.
Suggested by Roland Mainz.
