sd/source/ui/remotecontrol/mDNSResponder/dnssd_clientstub.c | 1 + 1 file changed, 1 insertion(+)
New commits: commit 229e85acd222a4ae9647c7a970269c87cb875b40 Author: Stephan Bergmann <sberg...@redhat.com> Date: Tue May 13 12:26:42 2014 +0200 elated fdo#60338: #error on umask(3) calls in currently unused code (as dnssd_clientstub.c is only used on Windows), should we ever want to use it. Change-Id: I5d9082ae69c505e4d60bbe8e60fdeaaf963a4614 diff --git a/sd/source/ui/remotecontrol/mDNSResponder/dnssd_clientstub.c b/sd/source/ui/remotecontrol/mDNSResponder/dnssd_clientstub.c index 1c4e084..0aa0717 100644 --- a/sd/source/ui/remotecontrol/mDNSResponder/dnssd_clientstub.c +++ b/sd/source/ui/remotecontrol/mDNSResponder/dnssd_clientstub.c @@ -621,6 +621,7 @@ static DNSServiceErrorType deliver_request(ipc_msg_hdr *hdr, DNSServiceOp *sdr) caddr.sun_len = sizeof(struct sockaddr_un); #endif strcpy(caddr.sun_path, data); +#error "the below umask(3) calls are bad in a MT program (cf. fdo#60338):" mask = umask(0); bindresult = bind(listenfd, (struct sockaddr *)&caddr, sizeof(caddr)); umask(mask); _______________________________________________ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits