On 12/02/2013 04:13 PM, Stephan Bergmann wrote:
On 11/27/2013 04:44 PM, Stephan Bergmann wrote:
Below are two commits that were necessary to make (Linux) "make check"
work again post
<http://cgit.freedesktop.org/libreoffice/core/commit/?id=efb23f29983f87104a684e7fab00b84fc59d131d>
"Integrate branch of IAccessible2." In both cases, the problematic
changes made by that commit looked rather unmotivated to me, and I do
not know whether it would actually have been better to change the code
under test or the test code. So, insight welcome.
And one more oddity:
commit 1cb1dca1260da2cea5b6800483e86a6d6b251844
Author: Stephan Bergmann <sberg...@redhat.com>
Date: Mon Dec 2 16:09:47 2013 +0100
Revert SwAccessibleCell::getCurrentValue to return a numeric value
again
76c549eb01dcb7b5bf28a271ce00e386f3d388ba "Integrate branch of
IAccessible2" had
changed it to return a string, but that neither matched the
documentation of
css.accessibility.XAccessibleValue nor did it satisfy
JunitTest_sw_unoapi. This
needs further clarification apparently.
Change-Id: Ib09f7549db7ba5155798d5917908c7ce50e7a592
...and its brother for sc:
commit e40bae2dc347ae6c7e3a9133fcdd78c62192a016
Author: Stephan Bergmann <sberg...@redhat.com>
Date: Tue Dec 3 09:30:25 2013 +0100
Revert ScAccessibleCellBase::getCurrentValue to reutnr a numeric value again
b41332475783c31136673fb44cf4c411bb0148f8 "Integrate branch of IAccessible2"
had
changed it to return a string, but that neither matched the documentation of
css.accessibility.XAccessibleValue nor did it satisfy JunitTest_sc_unoapi.
This
is the same underlying issue as 1cb1dca1260da2cea5b6800483e86a6d6b251844
"Revert
SwAccessibleCell::getCurrentValue to return a numeric value again" and needs
further clarification apparently.
Change-Id: Idb725724842ffa1aff811d66066912a22b2f2f6e
diff --git a/sc/source/ui/Accessibility/AccessibleCellBase.cxx
b/sc/source/ui/Accessibility/AccessibleCellBase.cxx
index d021dbd..d1817b3 100644
--- a/sc/source/ui/Accessibility/AccessibleCellBase.cxx
+++ b/sc/source/ui/Accessibility/AccessibleCellBase.cxx
@@ -233,8 +233,7 @@ uno::Any SAL_CALL
uno::Any aAny;
if (mpDoc)
{
- OUString
valStr(mpDoc->GetString(maCellAddress.Col(),maCellAddress.Row(),maCellAddress.Tab()));
- aAny <<= valStr;
+ aAny <<= mpDoc->GetValue(maCellAddress);
}
return aAny;
}
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
