[Libreoffice-commits] core.git: xmloff/source

[Noel Grandin]

 xmloff/source/forms/elementimport.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d47fb9474421e950b828a921565656babab9d9ba
Author: Noel Grandin <n...@peralex.com>
Date:   Mon Jun 3 10:37:33 2013 +0200

    fix for unused return value.
    
    This code was introduced by:
       commit d09dd8986436f17717443823ef18bd8552fdf408
       Author: Frank Schoenheit [fs] <frank.schoenh...@sun.com>
       Date:   Wed Sep 15 13:55:34 2010 +0200
       dba34a: export/import min-/max-/default-/value for date/time as
       XML-Schema conformant strings
    It looks like it intended to use determineDefaultServiceName(), but
    neglected to store the return value.
    
    Change-Id: I1607f39cf771b594389492785c7e72478d44843a
    Reviewed-on: https://gerrit.libreoffice.org/4140
    Reviewed-by: Luboš Luňák <l.lu...@suse.cz>
    Tested-by: Luboš Luňák <l.lu...@suse.cz>

diff --git a/xmloff/source/forms/elementimport.cxx 
b/xmloff/source/forms/elementimport.cxx
index 9d180b0..443209f 100644
--- a/xmloff/source/forms/elementimport.cxx
+++ b/xmloff/source/forms/elementimport.cxx
@@ -184,7 +184,7 @@ namespace xmloff
         }
 
         if ( m_sServiceName.isEmpty() )
-            determineDefaultServiceName();
+            m_sServiceName = determineDefaultServiceName();
 
         // create the object *now*. This allows setting properties in the 
various handleAttribute methods.
         // (Though currently not all code is migrated to this pattern, most 
attributes are still handled

_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits