On Sun, Apr 28, 2013 at 06:04:04AM +0000, Ahmad Harthi (via Code Review) wrote: > Hi, > > I have submitted a patch for review: > > https://gerrit.libreoffice.org/3644 > > To pull it, you can do: > > git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/3644/1 > > fdo#35320 A fix for Arabic justification problem caused by kashidas > > diff --git a/vcl/source/gdi/sallayout.cxx b/vcl/source/gdi/sallayout.cxx > index 9d315e3..d4696c7 100644 > --- a/vcl/source/gdi/sallayout.cxx > +++ b/vcl/source/gdi/sallayout.cxx > @@ -1274,7 +1274,7 @@ > // calculate gap, ignore if too small > int nGapWidth = pG->mnNewWidth - pG->mnOrigWidth; > // worst case is one kashida even for mini-gaps > - if( 3 * nGapWidth < nKashidaWidth ) > + if( nGapWidth < nKashidaWidth ) > continue; > > nKashidaCount = 0;
Can we have some explanation what the patch is doing? Neither the commit message nor the bugzilla issue explain the fix. Regards, Khaled _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
