Hey! i am here by attaching my patch for fdo#62096. Regards, Janit
On Sat, Apr 20, 2013 at 12:47 AM, Eike Rathke <er...@redhat.com> wrote: > Hi Janit, > > On Wednesday, 2013-04-17 00:00:39 +0530, Janit Anjaria wrote: > > > - if ( sInstModel.compareTo( pProps->Name ) == 0 ) > > + if ( sInstModel == ( pProps->Name ) ) > > I'd prefer if you removed also the now extraneous parenthesis > additionally to the .compareTo, so that would look like > > if ( sInstModel == pProps->Name ) > > It's just easier to parse for the eye ;-) Maybe it's just me, but > I feel tricked into "that's a function lacking the function name" ... > > And please, use fdo#62096 instead of BUG#62096 > > Thanks > Eike > > -- > LibreOffice Calc developer. Number formatter stricken i18n > transpositionizer. > GPG key ID: 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A > For key transition see http://erack.de/key-transition-2013-01-10.txt.asc > Support the FSFE, care about Free Software! > https://fsfe.org/support/?erack >
0001-fdo-62096-Replace-OUString-compareTo-wiht-operator.patch
Description: Binary data
_______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
