On 03/25/2013 01:20 PM, Petr Mladek wrote:

I see that the method "cGlobal::OpenURL" is used on more locations in
the "sc" module, for example when you handle SID_OPEN_HYPERLINK. I can't
find what this means. I guess that it is a toolbar, menu, or dialog
entry. This call should probably ignore the security setting because it
is not the pure mouse click.

Ah good point.  Even I didn't think of that possibility. ;-)

But from what I can gather, SID_OPEN_HYPERLINK, at least in Calc, is used only for edit text objects and drawing objects with hyperlink attributes. So, the way he made changes *should* be okay.

I add some Calc experts into CC. I hope that they could help :-)

I've already pushed it to master, and I'm about to backport it to 4.0 with my sign off.

PS: It would be great to modify also the helper text that is shown when
you hover over the link. It currently shows the target URL. If you look
into Writer, it shows "Ctrl-click to open hyperlink: http://..."; I think
that it is related to STR_HYPERLINK_CLICK, see
source/ui/utlui/initui.src.

Yup, this would be a nice polish indeed.

Kohei


--
Kohei Yoshida, LibreOffice hacker, Calc
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to