Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2872
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/72/2872/1
Related to coverity#704822 (Explicit null dereference)
aSlotIds.push_back(0) => aSlotIds can't be empty => pSlotIds can't be null
So no 704822
Change-Id: I52237fcd4f160a294c23307c2e33b515372b3c92
---
M svx/source/form/fmshimp.cxx
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/svx/source/form/fmshimp.cxx b/svx/source/form/fmshimp.cxx
index 7226140..1685ace 100644
--- a/svx/source/form/fmshimp.cxx
+++ b/svx/source/form/fmshimp.cxx
@@ -883,7 +883,7 @@
// and, last but not least, SFX wants the ids to be sorted
::std::sort( aSlotIds.begin(), aSlotIds.end() - 1 );
- sal_uInt16 *pSlotIds = aSlotIds.empty() ? 0 : &(aSlotIds[0]);
+ sal_uInt16 *pSlotIds = &(aSlotIds[0]);
m_pShell->GetViewShell()->GetViewFrame()->GetBindings().Invalidate(
pSlotIds );
}
}
--
To view, visit https://gerrit.libreoffice.org/2872
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I52237fcd4f160a294c23307c2e33b515372b3c92
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet <serval2...@yahoo.fr>
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
