Hi Alex,
On Sat, 2013-03-16 at 13:16 -0700, Alex Ivan wrote:
> Michael Meeks-2 wrote
> >> I've been looking into bug #60700
> >> <https://bugs.freedesktop.org/show_bug.cgi?id=60700> and have
>
> The first place that i found where these directories are created is in
> framework/source/uiconfiguration/uiconfigurationmanager.cxx:
> void UIConfigurationManager::impl_Initialize()
Yes indeed - odd that we create the storage elements there :-) no idea
why we do that; prolly worth checking that out:
> ...
> xElementTypeStorage = m_xDocConfigStorage->openStorageElement(
> rtl::OUString::createFromAscii( UIELEMENTTYPENAMES[i] ), nModes );
> ...
>
> Without this bit, an empty .odf does not end up containing those
> directories.
Nice ;-) I wonder though whether we shouldn't un-conditionally load it
as read-only, and re-open it in the 'store' method as writeable if
indeed the document is write-able (?) Of course, we'd need to audit the
uses of the xStorage member.
> On the one hand, there are other similar calls in this and other files, so
> it may have just been a slip up when writing these. On the other hand, i
> didn't have any good examples to test this out.
Right - of course, finding something that actually uses this so we can
test the (already broken) feature would be useful :-)
> and, since no one responded to this for some time, i did not investigate
> further. I will do so now that there is at least one example and update
> you if if figure it out.
Thanks ! of course, if you run out of time, just dumping the research /
code pointers into the easy-hack for the next person might make it even
easier for them.
> Thank you for your help,
And thanks for your interest / research Alex :-)
All the best,
Michael.
--
michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
