On 27/02/2013 00:20, Caolán McNamara wrote:
On Wed, 2012-12-19 at 15:00 -0800, julien2412 wrote:
Hello,
Cppcheck detected this into svx/source/svdraw/svdoedge.cxx
[svdoedge.cxx:1450]: (style) Variable 'pPt1' is assigned a value that is
never used.
[svdoedge.cxx:1453]: (style) Variable 'pPt4' is assigned a value that is
never used
That SdrEdgeObj::ImpCalcEdgeTrack is one of the most unpleasantly long
and unreadable things I've seen in LibreOffice.
Either pPt1 and pPt4 assignations may really be removed or a change must be
done here.
git blame&& show on results indicate it's there since initial
OOo-ification in 2000. It looks like a dead loss to me to do anything
except remove the assignations that have no utility.
I pushed the fix on master (see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=2e8d0fcad75d9b28c384ddac03bb45186694231f)
Thank you!
Julien
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
