[Libreoffice-commits] core.git: xmloff/source

[Norbert Thiebaud]

 xmloff/source/text/txtfldi.cxx |   28 ++++++++++++++++------------
 1 file changed, 16 insertions(+), 12 deletions(-)

New commits:
commit bb717296bf66f0acb84d5f84c38390f3e44c7b62
Author: Norbert Thiebaud <nthieb...@gmail.com>
Date:   Fri Feb 22 01:43:39 2013 -0600

    coverity#705347 Missing break in switch
    
    Change-Id: Ife49c096722fff204a140be970aa0692281e8b86
    Reviewed-on: https://gerrit.libreoffice.org/2327
    Reviewed-by: Caolán McNamara <caol...@redhat.com>
    Tested-by: Caolán McNamara <caol...@redhat.com>

diff --git a/xmloff/source/text/txtfldi.cxx b/xmloff/source/text/txtfldi.cxx
index e7067ac..90d23a0 100644
--- a/xmloff/source/text/txtfldi.cxx
+++ b/xmloff/source/text/txtfldi.cxx
@@ -2670,22 +2670,26 @@ void XMLPageVarSetFieldImportContext::ProcessAttribute(
 {
     switch (nAttrToken)
     {
-        case XML_TOK_TEXTFIELD_ACTIVE:
+    case XML_TOK_TEXTFIELD_ACTIVE:
+    {
+        bool bTmp(false);
+        if (::sax::Converter::convertBool(bTmp, sAttrValue))
         {
-            bool bTmp(false);
-            if (::sax::Converter::convertBool(bTmp, sAttrValue))
-            {
-                bActive = bTmp;
-            }
+            bActive = bTmp;
         }
-        case XML_TOK_TEXTFIELD_PAGE_ADJUST:
+        break;
+    }
+    case XML_TOK_TEXTFIELD_PAGE_ADJUST:
+    {
+        sal_Int32 nTmp(0);
+        if (::sax::Converter::convertNumber(nTmp, sAttrValue))
         {
-            sal_Int32 nTmp;
-            if (::sax::Converter::convertNumber(nTmp, sAttrValue))
-            {
-                nAdjust = (sal_Int16)nTmp;
-            }
+            nAdjust = (sal_Int16)nTmp;
         }
+        break;
+    }
+    default:
+        break;
     }
 }
 

_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits