On Monday 14 of January 2013, Noel Grandin wrote: > OK, so I tried modifying my patch so that we have > number(sal_Int64) > number(float) > number(double) > > At which point my unit tests fail when passing a 32-bit value in because > the compiler does not > know which overload to use - this is on 64-bit Ubuntu using gcc 4.7.2 > > I can't add a sal_Int32 variant because I suspect that will make the > original problem come back, which was where > we started, with all the "static_cast<sal_Int32>" stuff. > > Any ideas?
You need to add overloads, for anything except signed/unsigned char/short: On Friday 11 of January 2013, Lubos Lunak wrote: > So, based on this, the best solution to the problem that I can see is > creating fromNumber() or number() , overloaded for all signed/unsigned > int/long/long long types and all floats because of the lame language > ambiguity. The original valueOf() can be wrapped inside #ifndef > LIBO_INTERNAL_ONLY after LO is moved away from this problematic function to > keep it only for external backwards compatibility, while LO itself will no > longer "have" it. So rather than bitting us in small ways every now and > then, the (possibly smaller in the end, if it wasn't for this discussion) > effort is spent now, and the effort is not that big (all the duplicates can > be only 6 lines, 2 for doxygen @overload @since, 4 for code forwarding to > the overload taking the largest type). -- Lubos Lunak l.lu...@suse.cz _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
