Hi, On Wed, Jan 02, 2013 at 05:32:45PM +0100, Lubos Lunak wrote: > On Tuesday 01 of January 2013, Libreoffice Gerrit user wrote: > > commit 085e0adf53baff298059980a54758d81b08bb059 > > Author: David Tardon <dtar...@redhat.com> > > Date: Tue Jan 1 11:47:56 2013 +0100 > > > > just pass the define through -D > > > > I am constantly amazed at the creativity of the original makefile > > writers. An extra header file, processed by sed, rather then adding one > > item to CDEFS? Really? > > Please use config_xxx.h files rather than -D flags whenever possible (which, > interestingly, is an extra header file, processed by sed, rather than adding > one item to CDEFS).
But it is a "standard" way of adding defined symbols (i.e., the header is created automagically by configure). Writing a custom makefile code that runs sed and produces a header file is not standard (and never has been). D. _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
