On Saturday 08 of December 2012, Libreoffice Gerrit user wrote:
> xmloff/source/core/DocumentSettingsContext.cxx | 42 +--
> xmloff/source/core/DomExport.cxx | 4
> xmloff/source/core/SettingsExportHelper.cxx | 54 ++--
> xmloff/source/core/XMLEmbeddedObjectImportContext.cxx | 2
> xmloff/source/core/xmlexp.cxx | 10
> xmloff/source/core/xmlimp.cxx | 229
> ++++++------------ xmloff/source/core/xmlmultiimagehelper.cxx |
> 16 -
> 7 files changed, 140 insertions(+), 217 deletions(-)
>
> New commits:
> commit 649c6b38911e9b77d21efba5fa1d6affa9fc4b0e
> Author: Chr. Rossmanith <chrrossman...@gmx.de>
> Date: Tue Dec 4 14:35:40 2012 +0100
>
> RTL_CONSTASCII_USTRINGPARAM clean up
...
> diff --git a/xmloff/source/core/xmlmultiimagehelper.cxx
> b/xmloff/source/core/xmlmultiimagehelper.cxx index c2214f2..e060de1 100644
> --- a/xmloff/source/core/xmlmultiimagehelper.cxx
> +++ b/xmloff/source/core/xmlmultiimagehelper.cxx
> @@ -33,37 +33,37 @@ namespace
> sal_uInt32 nRetval(0);
>
> // pixel formats first
> - if(rString.endsWithAsciiL(RTL_CONSTASCII_STRINGPARAM(".bmp")))
> + if(rString.endsWithAsciiL(".bmp", 4))
> {
> return 10;
> }
> - if(rString.endsWithAsciiL(RTL_CONSTASCII_STRINGPARAM(".gif")))
> + if(rString.endsWithAsciiL(".gif", 4))
...
These should be rString.endsWith( ".gif" ) . Specifying the length manually
is error-prone and unnecessary.
--
Lubos Lunak
l.lu...@suse.cz
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
