On Friday 07 of December 2012, Norbert Thiebaud wrote: > On Fri, Dec 7, 2012 at 12:56 PM, Lubos Lunak <l.lu...@suse.cz> wrote: > > On Friday 07 of December 2012, Norbert Thiebaud wrote: > >> and we could also mandate that every source need to include > >> #include <config/lo.h> > >> or some some other thoroughly bikesheded name > >> which would in turn include the global config, sal/config and other > >> fundamental includes > > > > I seem to remember somebody has already said that this file is in fact > > sal/config.h , I'd just prefer to hear to for sure instead of seeming to > > remember it. > > That _cannot_ be sal/config.h > > sal/config is part of the URE.. it is published, it is very often > omitted and only included indrectly, and it cannot be used to group > commonly used include like ustring.hxx. > and certainly cannot be used to server LibreOffice centric hack purpose.
Yes, it can. SAL headers already include some stuff that is effectively LO-internal-only (logging, some string functionality), so it can as well #ifdef LIBO_INTERNAL_ONLY #include <config_global.h> #endif. > > In other news, I've already committed the two patches by mistake, so > > I'll keep them in unless somebody finds out something wrong with them. > > oh well...I still don't like to pollution of the build root with an > ever growing series of config_foo.h file... that will need to be added > to .gitignore... if they were in a config directory that would be much > neater and much easier to do a safe distro-clean They are in a config/ directory. -- Lubos Lunak l.lu...@suse.cz _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
