Hi David,
On 11/27/2012 12:28 PM, David Tardon wrote:
They directly modify configure and Makefile.in whereas liborcus uses
autoconf/automake which auto-generates these files.
I did it this way because I very much wanted to avoid having to run
autotools in our build (which is already complicated enough without it,
thank you). I suppose I should have put a note in...
Nah. That's okay. ;-) I was just making an observation; didn't mean to
criticize anyone's action.
So, I'll have to rely on the patch author (David?) to adjust them
once this branch is integrated into master. Sorry about this.
Now, if these changes do make sense in the liborcus package itself,
I'd be happy to merge them in upstream. I wasn't sure just by
looking at the changes alone...
You already did that :-)
Ah! Nice. With that, I'll drop these two patches. ;-)
Thanks a lot for the confirmation.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
