New branch 'feature/base-preview' available with the following commits: commit 047dfc3c6e5f92bb24464e61dcdb7387890fa207 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Tue Jul 24 17:59:11 2012 +0200
janitorial: C++-style cast instead of legacy C-style cast Change-Id: I86cd5d87751c5a9dd31a392e2b3847e8f5741524 commit 2e55ab2b62834b5e291d5202e2f53ba2761a3ca4 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Mon Jul 23 16:05:25 2012 +0200 TODO fdo#52179 Change-Id: I3144087cfe60b15a38853460f15a39ec730f0bf4 commit 34bede65812c70a1c63b7e5895b73ef50e9e0eac Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Tue Jul 24 17:15:55 2012 +0200 forcing repaint has catastrophic performance implications; invalidate only In Base: 1) Open a big table (hundreds of rows) 2) Only the first 40 to 100 rows are fetched into the cache and shown (depending on screen / window size). 3) Move to last row (click on icon |>|) 4) The last 40 to 100 rows are fetched into the cache; the data of the first 40/100 rows is pushed out of the cache. 5) The first 40 to 100 rows are fetched, just so that the call to rWindow.Paint() can do its job, because they are not in the cache anymore (!). The last 40/100 rows are pushed out of the cache. 6) The last 40 to 100 rows are fetched into the cache and displayed; the first 40/100 rows are pushed out of the cache *again*. Steps 5 and 6 are obviously *very* stupid. Change-Id: Ic11b893ea9440c2c5a142bd3c77c95d6730aa723 commit 66fa227f2b1bb9f1a8a963228c407d414dc463f3 Author: Terrence Enger <ten...@iseries-guru.com> Date: Wed Jul 18 14:46:11 2012 -0400 stop some leaked statement handles Change-Id: I06764e0569ea615e66de6cd5946614c7c538e60e Signed-off-by: Lionel Elie Mamane <lio...@mamane.lu> commit 470d9922835a74b417287d3c302580722d219349 Author: Terrence Enger <ten...@iseries-guru.com> Date: Wed Jul 18 14:46:11 2012 -0400 ODBMetaDataRS ctor: abort if statement handle allocation failed Change-Id: Ieac069565bbc14c909eeecf3e67588191191992f Signed-off-by: Lionel Elie Mamane <lio...@mamane.lu> commit ffb04635dbfd34cacd7874d1a9d1af79238e4ab1 Author: Terrence Enger <ten...@iseries-guru.com> Date: Wed Jul 18 14:46:11 2012 -0400 avoid freeing the NULL handle Change-Id: Id3f22bacfbf5e582656cc8ac38d60b781a25b4c3 Signed-off-by: Lionel Elie Mamane <lio...@mamane.lu> commit c237a94ab321d98919448402c8c2b9ca65399a6d Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Mon Jul 16 23:58:18 2012 +0200 fdo#51239 refresh row lazily (when data is requested) This avoids fetching data that will not be requested when the "cursor" is only moved and no data requested. That is typically what RowSetCache does when its own cursor is moved within its window. This basically makes the whole {next,previous,absolute,...}_checked story obsolete, by basically always being as fast as the i_bFetchRow==false case, but in a safer way. Change-Id: I89eaf277069736b3077bde8b45325929db290f2d commit f33b2c1de33fe66413b03e6a28a70a482d2405e4 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Thu Jul 12 23:28:10 2012 +0200 errors to stderr Change-Id: I01756622dd7700d3918d156f118cd69c8a15879a commit 69caae9dfaa37287fbab235fabeb2748c4dcefbc Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Thu Jul 12 18:10:14 2012 +0200 debug unexpected exception Change-Id: I404072caf6ddab0ed833586066507c7d332fcea4 commit 8dd4a862e659efb877ba3ca32679b14b4e5158b7 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Thu Jul 12 13:07:03 2012 +0200 fix hsqldb java version detection 1) The values were not properly exclusive. E.g. when compiling under OpenJDK 1.6, iscjava12 was set (!) 2) On Java 1.6, should not enable the parts that are (only) for Java7! 3) When non-JAVA7, need to preprocess the files that have JAVA7-only code, so that it gets removed Change-Id: I99b6bd9e781fee1007a04a4dc3d3f952c1b2eb00 commit 2540ca5f8ecbf0751e345db6604670ae06e87620 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Tue Jul 3 20:17:01 2012 +0200 embedded HSQLDB: reclaim space occupied by deleted rows Disadvantage is that saving/closing the file may take a significantly longer time Change-Id: I1cc35c34b49e60d73e8d341549c5a3c5ef314b6d commit 3c4428fdaa649c21d09f81bdfaa5688e0c7928b2 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Mon Jul 2 19:33:38 2012 +0200 LEM notes Change-Id: I16939e5d6e1f7c0a83f7f2b2dbc9a5b397b45c36 commit 1e4f693eb65e6eccd579d859543b63ee76722c6d Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Mon Jul 2 14:48:03 2012 +0200 janitorial: remove unused xParamsAsNames variable Change-Id: Ic4fe24faf75d38a8123a8f0e8304c054760bad85 commit c47c625d01feb357edb1ed937a2dfd5e7fab5cd1 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Wed Jun 6 14:28:50 2012 +0200 legacy reports: unify treatment of query and table In *both* cases, the value of hidden control "Sorting" (if non-empty) decides the columns being sorted on. Change-Id: I7f4b50c3af8c12e48e5dedd36b5877ad7a9e1b66 commit 74f934dcb65072c0244fbc4e47d498cb7e795e47 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Wed Jun 6 14:26:58 2012 +0200 legacy report wizard: when source is table, save name in QueryName Change-Id: Ie0bdbed9578b95f7fccc3d9ff6d9c8b5b91ac0ab commit c761a90a0d985129ae16f2f784721a976a30b5e5 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Wed Jun 6 14:25:51 2012 +0200 SQLQueryComposer allow setQueryCommand with prependSorting instead of append Change-Id: Ia06794537ea4d0f6f069c83709792ebbcc084804 commit 00acda040c14945ef62570a210ce1627d5a2d891 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Wed Jun 6 14:24:54 2012 +0200 db.SQLQueryComposer allow prependSortingCriteria call with addAliasFieldNames Change-Id: I05889ccac213743a55c302bd7249b30f817c0428 commit cf7d4e473014c22363b4a86fa84bec958acd5107 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Wed Jun 6 14:23:50 2012 +0200 cleanup Change-Id: I1ce4279d434ffa58328e17863b2e68af1e813a99 commit 92fa3dca0d7da57da960d75ebc261e7e568dca3b Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Wed Jun 6 14:23:30 2012 +0200 untabify Change-Id: I984c84534cb4c6cda8bd73a43d79ec8e49afcdeb commit 7aaa581fc389ec3bd73b1492485722290ad8047a Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Mon Jun 4 17:40:30 2012 +0200 Cleanup m_xSet in destructor Change-Id: I3d7023fcb1857da1ef107a8af0d373b9ca464f03 commit f8292e505ac9f974a13c5e547b5f4e2bc2910f54 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Mon Jun 4 17:35:52 2012 +0200 typos in comments Change-Id: I1dbb1990033602d7909ecdee72b8b699cce44cab commit e3c741ae5a474b66825c15a9e70f0ebce7659eff Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Mon Jun 4 17:31:25 2012 +0200 Remove wrong optimisation fixup of d4ae29a37873843c20fe7d5f5f071f8fb201fed9 after the call to m_pCacheSet->absolute_checked, the data *is* used, so we cannot anymore exempt m_pCacheSet from giving correct data. Change-Id: I7d3644ca08ce43cb030a80984605a1f8a8a64211 commit b0d3ab732fe80aa898268b7755f755d24fa77846 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Fri Jun 1 15:42:27 2012 +0200 OKeySet::refreshRow: Invalidate m_xRow/m_xSet when BeforeFirst or AfterLast Change-Id: I0f48c099eddc077b2a89e3b7fab66b5da55b57c8 commit c95099dc5057bd1db2c44ea730b7fb8bf1be6667 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Fri Jun 1 14:49:02 2012 +0200 Update comments Change-Id: I7e3f09d61cb35165000a35c8d3c3f2d284cf164e commit 1acbaabbdbc355260f3b5a8de82a85f1f2cf5524 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Wed Apr 4 16:00:52 2012 +0200 ORowSetCache::moveWindow m_nEndPos == m_nStartPos == 0 is OK commit 02fe11eb3dad60f91647a571ccb89ee7aa7c1d4e Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Mon Feb 27 13:47:24 2012 +0100 fdo#46675: fixup commit 0933aa88ab6e4a588deac00c6bd23c71bcd6ec35 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Mon Feb 27 13:10:40 2012 +0100 fdo#46675: expand group memberships in get*Privileges commit e7678cca26f1f2d5e2a553e4a93732498fdd13d1 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Thu Feb 16 09:29:54 2012 +0100 correct indentation commit 7f597c6cdfcf6408f4cca0cc4a7a9797e6b5f012 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Thu Feb 16 09:11:08 2012 +0100 typo & copy/paste error in error message commit 868ef4ee9408eecb0b6572d5a8aeee4117b849e9 Author: Kate Goss <katherine.g...@gmail.com> Date: Mon Feb 13 21:53:08 2012 +0000 Remove unused code from connectivity::odbc::OPreparedStatement Remove methods getDataBuf(int), getParamLength(int), getPrecision(int). commit 6baa1e035a69b6d2c64df79eeb7db05c20d36b7f Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Tue Feb 14 19:41:08 2012 +0100 ODBC: align *all* the handling of SQLULEN properties with maximal ODBC size commit 8179c2f243a9192884f855e62f2dc2e5ad16e871 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Tue Feb 14 19:39:01 2012 +0100 comphelper: add getINT64 commit 79a0b4d5132636c3711c4496cd05cc6d6f67af3a Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Tue Feb 14 18:34:52 2012 +0100 improve OTools::binParameter/bindData interaction Don't duplicate the decision point for "data at execution or copied data" commit 00a669ec09dee72557f7af1265507566a4c19f13 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Tue Feb 14 09:49:19 2012 +0100 new[] already allocates each element of the array And calls the default constructor, naturally. commit 28febd719921229d615dd3b7e60b81bad19b93ca Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Tue Feb 14 06:27:51 2012 +0100 odbc getTableTypes: ask the driver instead of guessing commit 67584c1ff520b4d95cec62df056fdb22686f390f Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Mon Feb 13 17:53:19 2012 +0100 ResMgr::TestStack more robust commit 829a956e39b503b19605c171ce516d4ec9b3542d Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Thu Feb 9 13:06:27 2012 +0100 reorganise code for better readability No behaviour change intended. However, if behaviour changed, probably the *old* behaviour is buggy, not new one. commit 2b67cfa21326ce5367d5ea4d9cbf9ebcad42ee3b Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Thu Feb 9 13:04:34 2012 +0100 typo in comment commit 7b4162a76cf92ff1842f722ac4bec6da232879ef Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Thu Feb 9 13:03:24 2012 +0100 ORowSetCache::moveWindow: yet another off-by-one error commit 368d00cbe68a4316e6259547f6d5a4baf2cddd84 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Wed Feb 8 19:08:20 2012 +0100 ORowSetCache::moveWindow fix variable inversion; fixes subsequentcheck commit 99a75bf5dab9e4ae01601b8cf41a3a045106d766 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Wed Feb 8 12:41:54 2012 +0100 ORowSetCache: handle case total data < m_nFetchSize As a drive-by: fillMatrix update m_nEndSize commit 3dde72d842a5c84692707b5bdf33b0877300e23c Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Tue Jan 31 11:39:47 2012 +0100 pgsql: simpler / safer check for system column commit 0ba834ec94357ae19143eb55562eefd9afb4b4ae Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Wed Feb 1 18:28:59 2012 +0100 pgsql: implement getColumnPrivileges, generate statement only once commit 9e3b29676f820f2b57f4d7e61f1c3b4ef2351e59 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Wed Feb 1 18:03:40 2012 +0100 pgsql: clean comments commit 6dd5007aab896a0ade8920305b823f1ad59fb495 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Tue Jan 31 22:53:31 2012 +0100 ORowSetCache: keep m_nEndPos better up-to-date commit c6e0ee9460b8685b5f6b56982950ada825ec4895 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Tue Jan 24 22:20:31 2012 +0100 make OTools::getValue insanely safe, factorise get{Int,Long,Byte,...} commit 019f04fd8e89079a88dd7c13b42ae4451b539270 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Mon Jan 23 10:19:55 2012 +0100 ORowSetCache::fillMatrix(): fix case m_nFetchsize > table size When lowering m_nStartPos, do not duplicate rows above its old value commit df110d55a3c0ae47a20a132b0eacdeaf5badda9f Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Sun Jan 22 01:35:58 2012 +0100 ORowSetCache::fillMatrix(): correct off-by-one error Symptom: segfault. Thanks to Julien Nabet for precise pointer to problematic code. commit a1a76734a826697026ae65e18dc1ccac5d2ced8c Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Thu Jan 19 20:20:06 2012 +0100 ORowSetCache: overhaul internals commit 63386ed52a0d7ccb30d23aed1efb00a8fd3035bd Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Thu Jan 19 17:54:10 2012 +0100 janitorial: don't rely on detail of current OSL_ENSURE implementation As in: that the compiler won't see the variables in the condition when OSL_DEBUG_LEVEL==0 commit cb7d56fe11689de0f9533e600830ba3260296d8e Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Thu Jan 19 17:49:32 2012 +0100 column position 0 is perfectly valid On the other hand, column position 1 is not guaranteed to exist. nCurPos will be BROWSER_INVALID_ID, not 0, in case of error in setting it commit 12699f3a0ff2022ab04a4f268baf6965a6906772 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Wed Jan 18 12:31:06 2012 +0100 janitorial: typo in comments commit 4687381784df561d69616e006910ba077580d750 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Tue Jan 17 13:34:04 2012 +0100 DbGridControl::SeekCursor: show exception when seek fails (and debug build) commit 92298d2d2e4bdae3e4fea4f01a1521be766adbdd Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Tue Jan 17 09:27:40 2012 +0100 janitorial: typo in private member name commit e9aca9a7273be37aeec9c5789525b2b9bea06975 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Tue Jan 17 09:26:41 2012 +0100 janitorial: const iterator where may be, indentation commit 914241f812e8140feafa49ba430a270e1b45fb07 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Tue Jan 17 15:21:41 2012 +0100 Also teach "foo IS [NOT] bar" to our SQL parser (when bar is not NULL) Syntax supported by at least SQLite. commit 3a56b717dbea5909a5e0a7890ca480c83fde46fa Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Tue Jan 17 09:03:17 2012 +0100 fdo#44813: teach "IS (NOT) DISTINCT FROM" to our SQL parser commit 4191299f5c0244caecb289c8cc2fbae0cb939bb6 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Sun Nov 20 17:37:39 2011 +0100 LEM TODO note commit 9f63f6f0b283e02d44393efb929a3877a20e5400 Author: Lionel Elie Mamane <lio...@mamane.lu> Date: Wed Nov 23 21:34:18 2011 +0100 maximal debugging information _______________________________________________ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits