>From Michael Stahl <mst...@redhat.com>: Michael Stahl has submitted this change and it was merged.
Change subject: fdo#46249: UCBContentHelper::GetTitle must not fail for void property ...................................................................... fdo#46249: UCBContentHelper::GetTitle must not fail for void property This was a regression introduced with 2af9040d38af7c7353855415dbea0134585058f3 "Cleaned up utl::UCBContentHelper." GetSize exhibited the same problem and has also been fixed. IsYounger exhibits a similar problem, but has not been addressed, as it is unclear what to return in case no dates can be compared; it is only used in one place (handling SID_EDITDOC in SfxViewFrame::ExecReload_Impl, sfx2/source/view/viewfrm.cxx) where, it appears, only contents for which DateModified /does/ yield a non-void value are relevant. Change-Id: Iff9f5e1ed6f45eede117713d64a265b98f6862b1 --- M unotools/inc/unotools/ucbhelper.hxx M unotools/source/ucbhelper/ucbhelper.cxx 2 files changed, 15 insertions(+), 9 deletions(-) Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/449 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff9f5e1ed6f45eede117713d64a265b98f6862b1 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: libreoffice-3-6 Gerrit-Owner: LibreOffice gerrit bot <ger...@libreoffice.org> Gerrit-Reviewer: Michael Stahl <mst...@redhat.com> Gerrit-Reviewer: Stephan Bergmann <sberg...@redhat.com> _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
