Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
40 new defect(s) introduced to LibreOffice found with Coverity Scan.
482 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 20 of 40 defect(s)
** CID 1693828: Uninitialized variables (UNINIT)
/vcl/qt5/QtInstanceItemView.cxx: 63 in
QtInstanceItemView::get_iter_index_in_parent(const weld::TreeIter &) const()
_____________________________________________________________________________________________
*** CID 1693828: Uninitialized variables (UNINIT)
/vcl/qt5/QtInstanceItemView.cxx: 63 in
QtInstanceItemView::get_iter_index_in_parent(const weld::TreeIter &) const()
57 int nIndex;
58 GetQtInstance().RunInMainThread([&] {
59 const QModelIndex aIndex = modelIndex(rIter);
60 nIndex = aIndex.row();
61 });
62
>>> CID 1693828: Uninitialized variables (UNINIT)
>>> Using uninitialized value "nIndex".
63 return nIndex;
64 }
65
66 std::unique_ptr<weld::TreeIter> QtInstanceItemView::get_iterator(int
nPos) const
67 {
68 const QModelIndex aIndex = modelIndex(nPos);
** CID 1693827: Possible Control flow issues (DEADCODE)
/dbaccess/source/ui/dlg/detailpages.cxx: 468 in
dbaui::OGeneralSpecialJDBCDetailsPage::OnTestJavaClickHdl(weld::Button &)()
_____________________________________________________________________________________________
*** CID 1693827: Possible Control flow issues (DEADCODE)
/dbaccess/source/ui/dlg/detailpages.cxx: 468 in
dbaui::OGeneralSpecialJDBCDetailsPage::OnTestJavaClickHdl(weld::Button &)()
462 }
463 catch(Exception&)
464 {
465 }
466 #endif
467 TranslateId pMessage = bSuccess ? STR_JDBCDRIVER_SUCCESS :
STR_JDBCDRIVER_NO_SUCCESS;
>>> CID 1693827: Possible Control flow issues (DEADCODE)
>>> Execution cannot reach the expression "dbaui::MessageType::Info" inside
>>> this statement: "mt = (bSuccess ? dbaui::Mes...".
468 const MessageType mt = bSuccess ? MessageType::Info :
MessageType::Error;
469 OSQLMessageBox aMsg(GetFrameWeld(), DBA_RES(pMessage),
OUString(), MessBoxStyle::Ok | MessBoxStyle::DefaultOk, mt);
470 aMsg.run();
471 }
472
473 void OGeneralSpecialJDBCDetailsPage::callModifiedHdl(weld::Widget*
pControl)
** CID 1693826: Uninitialized members (UNINIT_CTOR)
/vcl/inc/qt5/QtOpenGLContext.hxx: 51 in
QtOpenGLContext::QtOpenGLContext()()
_____________________________________________________________________________________________
*** CID 1693826: Uninitialized members (UNINIT_CTOR)
/vcl/inc/qt5/QtOpenGLContext.hxx: 51 in
QtOpenGLContext::QtOpenGLContext()()
45
46 static bool g_bAnyCurrent;
47
48 GLWindow m_aGLWin;
49
50 QWindow* m_pWindow;
>>> CID 1693826: Uninitialized members (UNINIT_CTOR)
>>> The compiler-generated constructor for this class does not initialize
>>> "m_pContext".
51 QOpenGLContext* m_pContext;
** CID 1693825: Uninitialized variables (UNINIT)
/vcl/qt5/QtInstanceTreeView.cxx: 600 in
QtInstanceTreeView::n_children() const()
_____________________________________________________________________________________________
*** CID 1693825: Uninitialized variables (UNINIT)
/vcl/qt5/QtInstanceTreeView.cxx: 600 in
QtInstanceTreeView::n_children() const()
594 int nChildCount;
595 GetQtInstance().RunInMainThread([&] {
596 const QModelIndex aRootIndex
597 =
m_pModel->mapFromSource(m_pSourceModel->invisibleRootItem()->index());
598 nChildCount = m_pModel->rowCount(aRootIndex);
599 });
>>> CID 1693825: Uninitialized variables (UNINIT)
>>> Using uninitialized value "nChildCount".
600 return nChildCount;
601 }
602
603 void QtInstanceTreeView::make_sorted()
604 {
605 SolarMutexGuard g;
** CID 1693824: Possible Control flow issues (DEADCODE)
/dbaccess/source/ui/dlg/ConnectionPage.cxx: 249 in
dbaui::OConnectionTabPage::OnTestJavaClickHdl(weld::Button &)()
_____________________________________________________________________________________________
*** CID 1693824: Possible Control flow issues (DEADCODE)
/dbaccess/source/ui/dlg/ConnectionPage.cxx: 249 in
dbaui::OConnectionTabPage::OnTestJavaClickHdl(weld::Button &)()
243 catch(Exception&)
244 {
245 }
246 #endif
247
248 TranslateId pMessage = bSuccess ? STR_JDBCDRIVER_SUCCESS :
STR_JDBCDRIVER_NO_SUCCESS;
>>> CID 1693824: Possible Control flow issues (DEADCODE)
>>> Execution cannot reach the expression "dbaui::MessageType::Info" inside
>>> this statement: "mt = (bSuccess ? dbaui::Mes...".
249 const MessageType mt = bSuccess ? MessageType::Info :
MessageType::Error;
250 OSQLMessageBox aMsg(GetFrameWeld(), DBA_RES(pMessage),
OUString(), MessBoxStyle::Ok | MessBoxStyle::DefaultOk, mt);
251 aMsg.run();
252 }
253 bool OConnectionTabPage::checkTestConnection()
254 {
** CID 1693823: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/vcl/inc/qt5/QtDoubleSpinBox.hxx: 47 in
QtDoubleSpinBox::setParseTextFunction(std::function<TriState (const QString &,
double *)>)()
_____________________________________________________________________________________________
*** CID 1693823: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/vcl/inc/qt5/QtDoubleSpinBox.hxx: 47 in
QtDoubleSpinBox::setParseTextFunction(std::function<TriState (const QString &,
double *)>)()
41 {
42 m_aFormatValueFunction = aFunction;
43 }
44
45 void setParseTextFunction(std::function<TriState(const QString&,
double*)> aFunction)
46 {
>>> CID 1693823: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "aFunction" is copied in call to copy assignment for class
>>> "std::function<TriState (QString const &, double *)>", when it could be
>>> moved instead.
47 m_aParseTextFunction = aFunction;
48 }
49 };
50
** CID 1693822: (UNINIT)
/vcl/inc/qt5/QtInstance.hxx: 159 in
QtInstance::EmscriptenLightweightRunInMainThread<QtMenu::ImplAddMenuBarButton(const
QIcon &, const QString &, int)::[lambda() (instance 5)]>(T1 &&)()
/vcl/inc/qt5/QtInstance.hxx: 159 in
QtInstance::EmscriptenLightweightRunInMainThread<QtMenu::ImplAddMenuBarButton(const
QIcon &, const QString &, int)::[lambda() (instance 2)]>(T1 &&)()
/vcl/inc/qt5/QtInstance.hxx: 159 in
QtInstance::EmscriptenLightweightRunInMainThread<QtGraphicsBase::ImplGetResolution(const
QtFrame *, int &, int &)::[lambda() (instance 1)]>(T1 &&)()
/vcl/inc/qt5/QtInstance.hxx: 159 in
QtInstance::EmscriptenLightweightRunInMainThread<QtMenu::connectHelpShortcut(QMenu
*)::[lambda() (instance 1)]>(T1 &&)()
/vcl/inc/qt5/QtInstance.hxx: 159 in
QtInstance::EmscriptenLightweightRunInMainThread<QtGraphicsBase::ImplGetResolution(const
QtFrame *, int &, int &)::[lambda() (instance 1)]>(T1 &&)()
/vcl/inc/qt5/QtInstance.hxx: 159 in
QtInstance::EmscriptenLightweightRunInMainThread<QtGraphicsBase::ImplGetResolution(const
QtFrame *, int &, int &)::[lambda() (instance 1)]>(T1 &&)()
/vcl/inc/qt5/QtInstance.hxx: 159 in
QtInstance::EmscriptenLightweightRunInMainThread<QtMenu::ImplAddMenuBarButton(const
QIcon &, const QString &, int)::[lambda() (instance 3)]>(T1 &&)()
/vcl/inc/qt5/QtInstance.hxx: 159 in
QtInstance::EmscriptenLightweightRunInMainThread<QtMenu::ImplAddMenuBarButton(const
QIcon &, const QString &, int)::[lambda() (instance 1)]>(T1 &&)()
_____________________________________________________________________________________________
*** CID 1693822: (UNINIT)
/vcl/inc/qt5/QtInstance.hxx: 159 in
QtInstance::EmscriptenLightweightRunInMainThread<QtMenu::ImplAddMenuBarButton(const
QIcon &, const QString &, int)::[lambda() (instance 5)]>(T1 &&)()
153 }
154 else
155 {
156 std::invoke_result_t<F> ret;
157 EmscriptenLightweightRunInMainThread_(
158 [&func, &ret] { ret =
std::forward<std::invoke_result_t<F>>(func()); });
>>> CID 1693822: (UNINIT)
>>> Using uninitialized value "ret".
159 return ret;
160 }
161 }
162
163 virtual SalFrame* CreateFrame(SalFrame* pParent, SalFrameStyleFlags
nStyle) override;
164 virtual SalFrame* CreateChildFrame(SystemParentData* pParent,
/vcl/inc/qt5/QtInstance.hxx: 159 in
QtInstance::EmscriptenLightweightRunInMainThread<QtMenu::ImplAddMenuBarButton(const
QIcon &, const QString &, int)::[lambda() (instance 2)]>(T1 &&)()
153 }
154 else
155 {
156 std::invoke_result_t<F> ret;
157 EmscriptenLightweightRunInMainThread_(
158 [&func, &ret] { ret =
std::forward<std::invoke_result_t<F>>(func()); });
>>> CID 1693822: (UNINIT)
>>> Using uninitialized value "ret".
159 return ret;
160 }
161 }
162
163 virtual SalFrame* CreateFrame(SalFrame* pParent, SalFrameStyleFlags
nStyle) override;
164 virtual SalFrame* CreateChildFrame(SystemParentData* pParent,
/vcl/inc/qt5/QtInstance.hxx: 159 in
QtInstance::EmscriptenLightweightRunInMainThread<QtGraphicsBase::ImplGetResolution(const
QtFrame *, int &, int &)::[lambda() (instance 1)]>(T1 &&)()
153 }
154 else
155 {
156 std::invoke_result_t<F> ret;
157 EmscriptenLightweightRunInMainThread_(
158 [&func, &ret] { ret =
std::forward<std::invoke_result_t<F>>(func()); });
>>> CID 1693822: (UNINIT)
>>> Using uninitialized value "ret".
159 return ret;
160 }
161 }
162
163 virtual SalFrame* CreateFrame(SalFrame* pParent, SalFrameStyleFlags
nStyle) override;
164 virtual SalFrame* CreateChildFrame(SystemParentData* pParent,
/vcl/inc/qt5/QtInstance.hxx: 159 in
QtInstance::EmscriptenLightweightRunInMainThread<QtMenu::connectHelpShortcut(QMenu
*)::[lambda() (instance 1)]>(T1 &&)()
153 }
154 else
155 {
156 std::invoke_result_t<F> ret;
157 EmscriptenLightweightRunInMainThread_(
158 [&func, &ret] { ret =
std::forward<std::invoke_result_t<F>>(func()); });
>>> CID 1693822: (UNINIT)
>>> Using uninitialized value "ret".
159 return ret;
160 }
161 }
162
163 virtual SalFrame* CreateFrame(SalFrame* pParent, SalFrameStyleFlags
nStyle) override;
164 virtual SalFrame* CreateChildFrame(SystemParentData* pParent,
/vcl/inc/qt5/QtInstance.hxx: 159 in
QtInstance::EmscriptenLightweightRunInMainThread<QtGraphicsBase::ImplGetResolution(const
QtFrame *, int &, int &)::[lambda() (instance 1)]>(T1 &&)()
153 }
154 else
155 {
156 std::invoke_result_t<F> ret;
157 EmscriptenLightweightRunInMainThread_(
158 [&func, &ret] { ret =
std::forward<std::invoke_result_t<F>>(func()); });
>>> CID 1693822: (UNINIT)
>>> Using uninitialized value "ret".
159 return ret;
160 }
161 }
162
163 virtual SalFrame* CreateFrame(SalFrame* pParent, SalFrameStyleFlags
nStyle) override;
164 virtual SalFrame* CreateChildFrame(SystemParentData* pParent,
/vcl/inc/qt5/QtInstance.hxx: 159 in
QtInstance::EmscriptenLightweightRunInMainThread<QtGraphicsBase::ImplGetResolution(const
QtFrame *, int &, int &)::[lambda() (instance 1)]>(T1 &&)()
153 }
154 else
155 {
156 std::invoke_result_t<F> ret;
157 EmscriptenLightweightRunInMainThread_(
158 [&func, &ret] { ret =
std::forward<std::invoke_result_t<F>>(func()); });
>>> CID 1693822: (UNINIT)
>>> Using uninitialized value "ret".
159 return ret;
160 }
161 }
162
163 virtual SalFrame* CreateFrame(SalFrame* pParent, SalFrameStyleFlags
nStyle) override;
164 virtual SalFrame* CreateChildFrame(SystemParentData* pParent,
/vcl/inc/qt5/QtInstance.hxx: 159 in
QtInstance::EmscriptenLightweightRunInMainThread<QtMenu::ImplAddMenuBarButton(const
QIcon &, const QString &, int)::[lambda() (instance 3)]>(T1 &&)()
153 }
154 else
155 {
156 std::invoke_result_t<F> ret;
157 EmscriptenLightweightRunInMainThread_(
158 [&func, &ret] { ret =
std::forward<std::invoke_result_t<F>>(func()); });
>>> CID 1693822: (UNINIT)
>>> Using uninitialized value "ret".
159 return ret;
160 }
161 }
162
163 virtual SalFrame* CreateFrame(SalFrame* pParent, SalFrameStyleFlags
nStyle) override;
164 virtual SalFrame* CreateChildFrame(SystemParentData* pParent,
/vcl/inc/qt5/QtInstance.hxx: 159 in
QtInstance::EmscriptenLightweightRunInMainThread<QtMenu::ImplAddMenuBarButton(const
QIcon &, const QString &, int)::[lambda() (instance 1)]>(T1 &&)()
153 }
154 else
155 {
156 std::invoke_result_t<F> ret;
157 EmscriptenLightweightRunInMainThread_(
158 [&func, &ret] { ret =
std::forward<std::invoke_result_t<F>>(func()); });
>>> CID 1693822: (UNINIT)
>>> Using uninitialized value "ret".
159 return ret;
160 }
161 }
162
163 virtual SalFrame* CreateFrame(SalFrame* pParent, SalFrameStyleFlags
nStyle) override;
164 virtual SalFrame* CreateChildFrame(SystemParentData* pParent,
** CID 1693821: Uninitialized variables (UNINIT)
/vcl/qt5/QtFilePicker.cxx: 195 in QtFilePicker::execute()()
_____________________________________________________________________________________________
*** CID 1693821: Uninitialized variables (UNINIT)
/vcl/qt5/QtFilePicker.cxx: 195 in QtFilePicker::execute()()
189 SolarMutexGuard g;
190 QtInstance& rQtInstance = GetQtInstance();
191 if (!rQtInstance.IsMainThread())
192 {
193 sal_uInt16 ret;
194 rQtInstance.RunInMainThread([&ret, this]() { ret = execute();
});
>>> CID 1693821: Uninitialized variables (UNINIT)
>>> Using uninitialized value "ret".
195 return ret;
196 }
197
198 prepareExecute();
199 int result = m_pFileDialog->exec();
200
** CID 1693820: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
_____________________________________________________________________________________________
*** CID 1693820: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/vcl/qt5/QtAccessibleWidget.cxx: 298 in
QtAccessibleWidget::relations(QFlags<QAccessible::RelationFlag>) const()
292 if (xRelationSet.is())
293 {
294 int count = xRelationSet->getRelationCount();
295 for (int i = 0; i < count; i++)
296 {
297 AccessibleRelation aRelation = xRelationSet->getRelation(i);
>>> CID 1693820: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "aRelation" is passed-by-value as parameter to
>>> "com::sun::star::accessibility::AccessibleRelation::AccessibleRelation(com::sun::star::accessibility::AccessibleRelation
>>> const &) /*implicit =default*/", when it could be moved instead.
298 lcl_appendRelation(&relations, aRelation, match);
299 }
300 }
301
302 return relations;
303 }
** CID 1693819: Uninitialized variables (UNINIT)
/vcl/qt5/QtInstanceSpinButton.cxx: 75 in
QtInstanceSpinButton::get_floating_point_value() const()
_____________________________________________________________________________________________
*** CID 1693819: Uninitialized variables (UNINIT)
/vcl/qt5/QtInstanceSpinButton.cxx: 75 in
QtInstanceSpinButton::get_floating_point_value() const()
69 double QtInstanceSpinButton::get_floating_point_value() const
70 {
71 SolarMutexGuard g;
72
73 double fValue;
74 GetQtInstance().RunInMainThread([&] { fValue = m_pSpinBox->value();
});
>>> CID 1693819: Uninitialized variables (UNINIT)
>>> Using uninitialized value "fValue".
75 return fValue;
76 }
77
78 void QtInstanceSpinButton::set_floating_point_range(double fMin, double
fMax)
79 {
80 SolarMutexGuard g;
** CID 1693818: Uninitialized members (UNINIT_CTOR)
/vcl/qt5/QtDragAndDrop.cxx: 188 in QtDropTarget::QtDropTarget()()
_____________________________________________________________________________________________
*** CID 1693818: Uninitialized members (UNINIT_CTOR)
/vcl/qt5/QtDragAndDrop.cxx: 188 in QtDropTarget::QtDropTarget()()
182 return { u"com.sun.star.datatransfer.dnd.QtDragSource"_ustr };
183 }
184
185 QtDropTarget::QtDropTarget()
186 : m_nDropAction(datatransfer::dnd::DNDConstants::ACTION_NONE)
187 {
>>> CID 1693818: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "m_bDropSuccessful" is not initialized in this
>>> constructor nor in any functions that it calls.
188 }
189
190 OUString SAL_CALL QtDropTarget::getImplementationName()
191 {
192 return u"com.sun.star.datatransfer.dnd.VclQtDropTarget"_ustr;
193 }
** CID 1693817: Null pointer dereferences (REVERSE_INULL)
/vcl/qt5/QtBitmap.cxx: 52 in QtBitmap::Create(const Size &,
vcl::PixelFormat, const BitmapPalette &)()
_____________________________________________________________________________________________
*** CID 1693817: Null pointer dereferences (REVERSE_INULL)
/vcl/qt5/QtBitmap.cxx: 52 in QtBitmap::Create(const Size &,
vcl::PixelFormat, const BitmapPalette &)()
46
47 m_pImage.reset(new QImage(toQSize(rSize),
getBitFormat(ePixelFormat)));
48 m_pImage->fill(Qt::transparent);
49 m_aPalette = rPal;
50
51 auto count = rPal.GetEntryCount();
>>> CID 1693817: Null pointer dereferences (REVERSE_INULL)
>>> Null-checking "this->m_pImage" suggests that it may be null, but it has
>>> already been dereferenced on all paths leading to the check.
52 if (count && m_pImage)
53 {
54 QVector<QRgb> aColorTable(count);
55 for (unsigned i = 0; i < count; ++i)
56 aColorTable[i] = qRgb(rPal[i].GetRed(), rPal[i].GetGreen(),
rPal[i].GetBlue());
57 m_pImage->setColorTable(std::move(aColorTable));
** CID 1693816: Uninitialized variables (UNINIT)
/vcl/qt5/QtInstanceComboBox.cxx: 119 in
QtInstanceComboBox::get_active() const()
_____________________________________________________________________________________________
*** CID 1693816: Uninitialized variables (UNINIT)
/vcl/qt5/QtInstanceComboBox.cxx: 119 in
QtInstanceComboBox::get_active() const()
113
114 int QtInstanceComboBox::get_active() const
115 {
116 SolarMutexGuard g;
117 int nCurrentIndex;
118 GetQtInstance().RunInMainThread([&] { nCurrentIndex =
m_pComboBox->currentIndex(); });
>>> CID 1693816: Uninitialized variables (UNINIT)
>>> Using uninitialized value "nCurrentIndex".
119 return nCurrentIndex;
120 }
121
122 void QtInstanceComboBox::do_set_active(int nPos)
123 {
124 SolarMutexGuard g;
** CID 1693815: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/oox/source/drawingml/shapegroupcontext.cxx: 119 in
oox::drawingml::ShapeGroupContext::onCreateContext(int, const
oox::AttributeList &)()
_____________________________________________________________________________________________
*** CID 1693815: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/oox/source/drawingml/shapegroupcontext.cxx: 119 in
oox::drawingml::ShapeGroupContext::onCreateContext(int, const
oox::AttributeList &)()
113
114 // also set DataModelID to have these also available for the
imported
115 // replacement visualization. This is key to allow changes to
116 // DiagramHelper model changes
117 pShape->setDiagramDataModelID(aModelID);
118
>>> CID 1693815: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "pShape" is passed-by-value as parameter to
>>> "std::shared_ptr<oox::drawingml::Shape>::shared_ptr(std::shared_ptr<oox::drawingml::Shape>
>>> const &) /*explicit =default*/", when it could be moved instead.
119 return new ShapeContext( *this, mpGroupShapePtr, pShape );
120 }
121 case XML_pic: // CT_Picture
122 return new GraphicShapeContext( *this, mpGroupShapePtr,
std::make_shared<Shape>( "com.sun.star.drawing.GraphicObjectShape" ) );
123 case XML_graphicFrame: // CT_GraphicalObjectFrame
124 return new GraphicalObjectFrameContext( *this, mpGroupShapePtr,
std::make_shared<Shape>( "com.sun.star.drawing.GraphicObjectShape" ), true );
** CID 1693814: Uninitialized variables (UNINIT)
/vcl/qt5/QtInstanceGrid.cxx: 111 in
QtInstanceGrid::get_child_top_attach(weld::Widget &) const()
_____________________________________________________________________________________________
*** CID 1693814: Uninitialized variables (UNINIT)
/vcl/qt5/QtInstanceGrid.cxx: 111 in
QtInstanceGrid::get_child_top_attach(weld::Widget &) const()
105 int nCol = 0;
106 int nRowSpan = 0;
107 int nColSpan = 0;
108 getLayout().getItemPosition(getLayout().indexOf(pWidget),
&nRow, &nCol, &nRowSpan,
109 &nColSpan);
110 });
>>> CID 1693814: Uninitialized variables (UNINIT)
>>> Using uninitialized value "nRow".
111 return nRow;
112 }
113
114 QGridLayout& QtInstanceGrid::getLayout() const
115 {
116 return static_cast<QGridLayout&>(QtInstanceContainer::getLayout());
117 }
118
** CID 1693813: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/vcl/qt5/QtTreeViewItemDelegate.cxx: 21 in
QtTreeViewItemDelegate::QtTreeViewItemDelegate(QObject *, std::function<bool
(const QModelIndex &)>, std::function<bool (const QModelIndex &, const QString
&)>)()
_____________________________________________________________________________________________
*** CID 1693813: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/vcl/qt5/QtTreeViewItemDelegate.cxx: 21 in
QtTreeViewItemDelegate::QtTreeViewItemDelegate(QObject *, std::function<bool
(const QModelIndex &)>, std::function<bool (const QModelIndex &, const QString
&)>)()
15 #include <QtWidgets/QLineEdit>
16
17 QtTreeViewItemDelegate::QtTreeViewItemDelegate(
18 QObject* pParent, std::function<bool(const QModelIndex& rIndex)>
aStartEditingFunction,
19 std::function<bool(const QModelIndex& rIndex, const QString&
rNewText)> aFinishEditingFunction)
20 : QStyledItemDelegate(pParent)
>>> CID 1693813: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "aStartEditingFunction" is passed-by-value as parameter to
>>> "std::function<bool (QModelIndex const &)>::function(std::function<bool
>>> (QModelIndex const &)> const &)", when it could be moved instead.
21 , m_aStartEditingFunction(aStartEditingFunction)
22 , m_aFinishEditingFunction(aFinishEditingFunction)
23 {
24 }
25
26 QWidget* QtTreeViewItemDelegate::createEditor(QWidget* pParent, const
QStyleOptionViewItem& rOption,
** CID 1693812: (INVALIDATE_ITERATOR)
/sw/source/uibase/uitest/uiobject.cxx: 97 in
SwEditWinUIObject::execute(const rtl::OUString &, const std::map<rtl::OUString,
rtl::OUString, std::less<rtl::OUString>, std::allocator<std::pair<const
rtl::OUString, rtl::OUString>>> &)()
/sw/source/uibase/uitest/uiobject.cxx: 77 in
SwEditWinUIObject::execute(const rtl::OUString &, const std::map<rtl::OUString,
rtl::OUString, std::less<rtl::OUString>, std::allocator<std::pair<const
rtl::OUString, rtl::OUString>>> &)()
/sw/source/uibase/uitest/uiobject.cxx: 87 in
SwEditWinUIObject::execute(const rtl::OUString &, const std::map<rtl::OUString,
rtl::OUString, std::less<rtl::OUString>, std::allocator<std::pair<const
rtl::OUString, rtl::OUString>>> &)()
/sw/source/uibase/uitest/uiobject.cxx: 132 in
SwEditWinUIObject::execute(const rtl::OUString &, const std::map<rtl::OUString,
rtl::OUString, std::less<rtl::OUString>, std::allocator<std::pair<const
rtl::OUString, rtl::OUString>>> &)()
_____________________________________________________________________________________________
*** CID 1693812: (INVALIDATE_ITERATOR)
/sw/source/uibase/uitest/uiobject.cxx: 97 in
SwEditWinUIObject::execute(const rtl::OUString &, const std::map<rtl::OUString,
rtl::OUString, std::less<rtl::OUString>, std::allocator<std::pair<const
rtl::OUString, rtl::OUString>>> &)()
91 }
92 else if (rAction == "SELECT")
93 {
94 if (rParameters.contains(u"START_POS"_ustr))
95 {
96 auto itr = rParameters.find(u"START_POS"_ustr);
>>> CID 1693812: (INVALIDATE_ITERATOR)
>>> Dereferencing iterator "itr" though it is already past the end of its
>>> container.
97 OUString aStartPos = itr->second;
98 TextFrameIndex const nStartPos(aStartPos.toInt32());
99
100 itr = rParameters.find(u"END_POS"_ustr);
101 assert(itr != rParameters.end());
102 OUString aEndPos = itr->second;
/sw/source/uibase/uitest/uiobject.cxx: 77 in
SwEditWinUIObject::execute(const rtl::OUString &, const std::map<rtl::OUString,
rtl::OUString, std::less<rtl::OUString>, std::allocator<std::pair<const
rtl::OUString, rtl::OUString>>> &)()
71 {
72 if (rAction == "SET")
73 {
74 if (rParameters.contains(u"ZOOM"_ustr))
75 {
76 auto itr = rParameters.find(u"ZOOM"_ustr);
>>> CID 1693812: (INVALIDATE_ITERATOR)
>>> Dereferencing iterator "itr" though it is already past the end of its
>>> container.
77 OUString aVal = itr->second;
78 sal_Int32 nVal = aVal.toInt32();
79 mxEditWin->GetView().SetZoom(SvxZoomType::PERCENT, nVal);
80 }
81 }
82 else if (rAction == "GOTO")
/sw/source/uibase/uitest/uiobject.cxx: 87 in
SwEditWinUIObject::execute(const rtl::OUString &, const std::map<rtl::OUString,
rtl::OUString, std::less<rtl::OUString>, std::allocator<std::pair<const
rtl::OUString, rtl::OUString>>> &)()
81 }
82 else if (rAction == "GOTO")
83 {
84 if (rParameters.contains(u"PAGE"_ustr))
85 {
86 auto itr = rParameters.find(u"PAGE"_ustr);
>>> CID 1693812: (INVALIDATE_ITERATOR)
>>> Dereferencing iterator "itr" though it is already past the end of its
>>> container.
87 OUString aVal = itr->second;
88 sal_Int32 nVal = aVal.toInt32();
89 getWrtShell(mxEditWin).GotoPage(nVal, false);
90 }
91 }
92 else if (rAction == "SELECT")
/sw/source/uibase/uitest/uiobject.cxx: 132 in
SwEditWinUIObject::execute(const rtl::OUString &, const std::map<rtl::OUString,
rtl::OUString, std::less<rtl::OUString>, std::allocator<std::pair<const
rtl::OUString, rtl::OUString>>> &)()
126 SfxViewFrame* pViewFrm = SfxViewFrame::Current();
127 assert(pViewFrm && "SwEditWinUIObject::execute: no viewframe");
128 pViewFrm->ShowChildWindow(SID_SIDEBAR);
129 if (rParameters.contains(u"PANEL"_ustr))
130 {
131 auto itr = rParameters.find(u"PANEL"_ustr);
>>> CID 1693812: (INVALIDATE_ITERATOR)
>>> Dereferencing iterator "itr" though it is already past the end of its
>>> container.
132 OUString aVal = itr->second;
133 ::sfx2::sidebar::Sidebar::ShowPanel(aVal,
pViewFrm->GetFrame().GetFrameInterface());
134 }
135 }
136 else
137 WindowUIObject::execute(rAction, rParameters);
** CID 1693811: Integer handling issues (INTEGER_OVERFLOW)
/svx/source/gallery2/galini.cxx: 61 in
GalleryFileStorageEntry::ReadStrFromIni(std::basic_string_view<char,
std::char_traits<char>>) const()
_____________________________________________________________________________________________
*** CID 1693811: Integer handling issues (INTEGER_OVERFLOW)
/svx/source/gallery2/galini.cxx: 61 in
GalleryFileStorageEntry::ReadStrFromIni(std::basic_string_view<char,
std::char_traits<char>>) const()
55
56 size_t n = aLine.find('=');
57 if (n == std::string_view::npos)
58 continue;
59
60 std::string_view aKey(o3tl::trim(aLine.substr(0, n)));
>>> CID 1693811: Integer handling issues (INTEGER_OVERFLOW)
>>> Expression "n + 1UL", where "n" is known to be equal to
>>> 18446744073709551615, overflows the type of "n + 1UL", which is type
>>> "unsigned long".
61 std::string_view aValue(o3tl::trim(aLine.substr(n + 1)));
62
63 n = aKey.find('[');
64 if (n == std::string_view::npos || n < 1)
65 continue;
66
** CID 1693810: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/vcl/qt5/QtInstance.cxx: 230 in
QtInstance::RunInMainThread(std::function<void ()>)()
_____________________________________________________________________________________________
*** CID 1693810: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/vcl/qt5/QtInstance.cxx: 230 in
QtInstance::RunInMainThread(std::function<void ()>)()
224 #endif
225
226 QtYieldMutex* const
pMutex(static_cast<QtYieldMutex*>(GetYieldMutex()));
227 {
228 std::scoped_lock<std::mutex> g(pMutex->m_RunInMainMutex);
229 assert(!pMutex->m_Closure);
>>> CID 1693810: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "func" is copied in call to copy assignment for class
>>> "std::function<void ()>", when it could be moved instead.
230 pMutex->m_Closure = func;
231 // unblock main thread in case it is blocked on condition
232 pMutex->m_isWakeUpMain = true;
233 pMutex->m_InMainCondition.notify_all();
234 }
235
** CID 1693809: Uninitialized variables (UNINIT)
/vcl/qt5/QtInstanceComboBox.cxx: 98 in
QtInstanceComboBox::get_count() const()
_____________________________________________________________________________________________
*** CID 1693809: Uninitialized variables (UNINIT)
/vcl/qt5/QtInstanceComboBox.cxx: 98 in
QtInstanceComboBox::get_count() const()
92
93 int QtInstanceComboBox::get_count() const
94 {
95 SolarMutexGuard g;
96 int nCount;
97 GetQtInstance().RunInMainThread([&] { nCount = m_pComboBox->count();
});
>>> CID 1693809: Uninitialized variables (UNINIT)
>>> Using uninitialized value "nCount".
98 return nCount;
99 }
100
101 void QtInstanceComboBox::make_sorted()
102 {
103 SolarMutexGuard g;
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://scan.coverity.com/projects/libreoffice?tab=overview
